From: Tony Lindgren <tony@atomide.com>
To: Carlos Aguiar <carlos.aguiar@indt.org.br>
Cc: omap-linux <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1
Date: Mon, 26 Nov 2007 11:09:49 -0800 [thread overview]
Message-ID: <20071126190949.GE21886@atomide.com> (raw)
In-Reply-To: <474AEDFE.2030803@indt.org.br>
* Carlos Aguiar <carlos.aguiar@indt.org.br> [071126 08:05]:
> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>
> Adds MMC basic support for Siemens SX1 mobile phone.
>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
> drivers/mmc/host/omap.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 97b123e..4c5d91a 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1093,6 +1093,9 @@ static void mmc_omap_set_power(struct mmc_omap_slot *slot, int power_on,
> slot->pdata->set_power(mmc_dev(slot->mmc), slot->id, power_on,
> vdd);
>
> + if (machine_is_sx1())
> + sx1_setmmcpower(power_on);
> +
> if (cpu_is_omap24xx()) {
> u16 w;
There should not be need for board specific code in mmc/host/omap.c
any longer after these patches, so why not use the same set_power
interface for sx1 as other boards do?
Regards,
Tony
prev parent reply other threads:[~2007-11-26 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 16:02 [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1 Carlos Aguiar
2007-11-26 19:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126190949.GE21886@atomide.com \
--to=tony@atomide.com \
--cc=carlos.aguiar@indt.org.br \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox