From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1 Date: Mon, 26 Nov 2007 11:09:49 -0800 Message-ID: <20071126190949.GE21886@atomide.com> References: <474AEDFE.2030803@indt.org.br> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <474AEDFE.2030803@indt.org.br> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Carlos Aguiar Cc: omap-linux List-Id: linux-omap@vger.kernel.org * Carlos Aguiar [071126 08:05]: > From: Carlos Eduardo Aguiar > > Adds MMC basic support for Siemens SX1 mobile phone. > > Signed-off-by: Carlos Eduardo Aguiar > --- > drivers/mmc/host/omap.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c > index 97b123e..4c5d91a 100644 > --- a/drivers/mmc/host/omap.c > +++ b/drivers/mmc/host/omap.c > @@ -1093,6 +1093,9 @@ static void mmc_omap_set_power(struct mmc_omap_slot *slot, int power_on, > slot->pdata->set_power(mmc_dev(slot->mmc), slot->id, power_on, > vdd); > > + if (machine_is_sx1()) > + sx1_setmmcpower(power_on); > + > if (cpu_is_omap24xx()) { > u16 w; There should not be need for board specific code in mmc/host/omap.c any longer after these patches, so why not use the same set_power interface for sx1 as other boards do? Regards, Tony