* [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1
@ 2007-11-26 16:02 Carlos Aguiar
2007-11-26 19:09 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Aguiar @ 2007-11-26 16:02 UTC (permalink / raw)
To: omap-linux
From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
Adds MMC basic support for Siemens SX1 mobile phone.
Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
---
drivers/mmc/host/omap.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 97b123e..4c5d91a 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1093,6 +1093,9 @@ static void mmc_omap_set_power(struct mmc_omap_slot *slot, int power_on,
slot->pdata->set_power(mmc_dev(slot->mmc), slot->id, power_on,
vdd);
+ if (machine_is_sx1())
+ sx1_setmmcpower(power_on);
+
if (cpu_is_omap24xx()) {
u16 w;
-- 1.5.3.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1
2007-11-26 16:02 [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1 Carlos Aguiar
@ 2007-11-26 19:09 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-11-26 19:09 UTC (permalink / raw)
To: Carlos Aguiar; +Cc: omap-linux
* Carlos Aguiar <carlos.aguiar@indt.org.br> [071126 08:05]:
> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>
> Adds MMC basic support for Siemens SX1 mobile phone.
>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
> drivers/mmc/host/omap.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 97b123e..4c5d91a 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1093,6 +1093,9 @@ static void mmc_omap_set_power(struct mmc_omap_slot *slot, int power_on,
> slot->pdata->set_power(mmc_dev(slot->mmc), slot->id, power_on,
> vdd);
>
> + if (machine_is_sx1())
> + sx1_setmmcpower(power_on);
> +
> if (cpu_is_omap24xx()) {
> u16 w;
There should not be need for board specific code in mmc/host/omap.c
any longer after these patches, so why not use the same set_power
interface for sx1 as other boards do?
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-26 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-26 16:02 [PATCH 17/17] MMC: OMAP: Adds MMC basic support for Siemens SX1 Carlos Aguiar
2007-11-26 19:09 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox