From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [patch 2.6.24-rc3-omap1] i2c init section fixes Date: Wed, 28 Nov 2007 12:48:45 -0800 Message-ID: <20071128204844.GX11825@atomide.com> References: <200711232320.05916.david-b@pacbell.net> <20071126105400.0133e18f.jarkko.nikula@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20071126105400.0133e18f.jarkko.nikula@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Jarkko Nikula Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Jarkko Nikula [071126 00:59]: > On Fri, 23 Nov 2007 23:20:05 -0800 > "ext David Brownell" wrote: > > > Fix init section warnings in the new i2c init code. It's > > wrong to call "__init" functions from non-__init ones. > > > > Signed-off-by: David Brownell > > > > --- a/arch/arm/plat-omap/i2c.c > > +++ b/arch/arm/plat-omap/i2c.c > > > Since i2c_register_board_info is defined with __init, we have to define > functions here with __init as well. > > Acked-by: Jarkko Nikula > > --- > > How do I enable that warning since I don't see it now? I remember that I > saw some timer related __init warnings some time ago. I'm using > "gcc version 3.4.4 (release) (CodeSourcery ARM 2005q3-2)". Pushing today. Tony