* [patch 2.6.24-rc3-omap1] i2c init section fixes
@ 2007-11-24 7:20 David Brownell
2007-11-26 8:54 ` Jarkko Nikula
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2007-11-24 7:20 UTC (permalink / raw)
To: linux-omap-open-source
Fix init section warnings in the new i2c init code. It's
wrong to call "__init" functions from non-__init ones.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
--- a/arch/arm/plat-omap/i2c.c
+++ b/arch/arm/plat-omap/i2c.c
@@ -80,7 +80,7 @@ #if defined(CONFIG_ARCH_OMAP34XX)
#endif
};
-static void omap_i2c_mux_pins(int bus_id)
+static void __init omap_i2c_mux_pins(int bus_id)
{
/* TODO: Muxing for OMAP3 */
switch (bus_id) {
@@ -102,7 +102,7 @@ static void omap_i2c_mux_pins(int bus_id
}
}
-int omap_register_i2c_bus(int bus_id, u32 clkrate,
+int __init omap_register_i2c_bus(int bus_id, u32 clkrate,
struct i2c_board_info const *info,
unsigned len)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 2.6.24-rc3-omap1] i2c init section fixes
2007-11-24 7:20 [patch 2.6.24-rc3-omap1] i2c init section fixes David Brownell
@ 2007-11-26 8:54 ` Jarkko Nikula
2007-11-28 20:48 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2007-11-26 8:54 UTC (permalink / raw)
To: ext David Brownell; +Cc: linux-omap-open-source
On Fri, 23 Nov 2007 23:20:05 -0800
"ext David Brownell" <david-b@pacbell.net> wrote:
> Fix init section warnings in the new i2c init code. It's
> wrong to call "__init" functions from non-__init ones.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> --- a/arch/arm/plat-omap/i2c.c
> +++ b/arch/arm/plat-omap/i2c.c
>
Since i2c_register_board_info is defined with __init, we have to define
functions here with __init as well.
Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
How do I enable that warning since I don't see it now? I remember that I
saw some timer related __init warnings some time ago. I'm using
"gcc version 3.4.4 (release) (CodeSourcery ARM 2005q3-2)".
Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2.6.24-rc3-omap1] i2c init section fixes
2007-11-26 8:54 ` Jarkko Nikula
@ 2007-11-28 20:48 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2007-11-28 20:48 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-omap-open-source
* Jarkko Nikula <jarkko.nikula@nokia.com> [071126 00:59]:
> On Fri, 23 Nov 2007 23:20:05 -0800
> "ext David Brownell" <david-b@pacbell.net> wrote:
>
> > Fix init section warnings in the new i2c init code. It's
> > wrong to call "__init" functions from non-__init ones.
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> >
> > --- a/arch/arm/plat-omap/i2c.c
> > +++ b/arch/arm/plat-omap/i2c.c
> >
> Since i2c_register_board_info is defined with __init, we have to define
> functions here with __init as well.
>
> Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
>
> ---
>
> How do I enable that warning since I don't see it now? I remember that I
> saw some timer related __init warnings some time ago. I'm using
> "gcc version 3.4.4 (release) (CodeSourcery ARM 2005q3-2)".
Pushing today.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-28 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-24 7:20 [patch 2.6.24-rc3-omap1] i2c init section fixes David Brownell
2007-11-26 8:54 ` Jarkko Nikula
2007-11-28 20:48 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox