* [PATCH] - onenand - OMAP3 support - Kconfig update
@ 2007-11-19 12:30 Sameer
2007-11-19 12:39 ` Felipe Balbi
2007-11-20 7:32 ` [PATCH: Resending] " Sameer
0 siblings, 2 replies; 14+ messages in thread
From: Sameer @ 2007-11-19 12:30 UTC (permalink / raw)
To: linux-omap-open-source
Hi,
This patch enables the onenand Kconfig for OMAP3.
Regards,
-Sameer
Signed-off-by: Sameer <sameersu@ti.com>
---
drivers/mtd/onenand/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Index: linux-omap-git/drivers/mtd/onenand/Kconfig
===================================================================
--- linux-omap-git.orig/drivers/mtd/onenand/Kconfig
+++ linux-omap-git/drivers/mtd/onenand/Kconfig
@@ -28,10 +28,10 @@ config MTD_ONENAND_GENERIC
Support for OneNAND flash via platform device driver.
config MTD_ONENAND_OMAP2
- tristate "OneNAND on OMAP2 support"
- depends on MTD_ONENAND && ARCH_OMAP2
+ tristate "OneNAND on OMAP2/OMAP3 support"
+ depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3)
help
- Support for a OneNAND flash device connected to an OMAP2 CPU
+ Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU
via the GPMC memory controller.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] - onenand - OMAP3 support - Kconfig update 2007-11-19 12:30 [PATCH] - onenand - OMAP3 support - Kconfig update Sameer @ 2007-11-19 12:39 ` Felipe Balbi 2007-11-20 7:32 ` [PATCH: Resending] " Sameer 1 sibling, 0 replies; 14+ messages in thread From: Felipe Balbi @ 2007-11-19 12:39 UTC (permalink / raw) To: Sameer; +Cc: linux-omap-open-source Hi, On Mon, 19 Nov 2007 18:00:32 +0530, "Sameer" <x0081444@ti.com> wrote: > Hi, > This patch enables the onenand Kconfig for OMAP3. > > Regards, > -Sameer > > Signed-off-by: Sameer <sameersu@ti.com> > --- > drivers/mtd/onenand/Kconfig | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > Index: linux-omap-git/drivers/mtd/onenand/Kconfig > =================================================================== > --- linux-omap-git.orig/drivers/mtd/onenand/Kconfig > +++ linux-omap-git/drivers/mtd/onenand/Kconfig > @@ -28,10 +28,10 @@ config MTD_ONENAND_GENERIC > Support for OneNAND flash via platform device driver. > > config MTD_ONENAND_OMAP2 > - tristate "OneNAND on OMAP2 support" > - depends on MTD_ONENAND && ARCH_OMAP2 > + tristate "OneNAND on OMAP2/OMAP3 support" > + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) > help > - Support for a OneNAND flash device connected to an OMAP2 CPU > + Support for a OneNAND flash device connected to an OMAP2/OMAP3 > CPU > via the GPMC memory controller. > It looks good to me and I can say it's working although maybe Tony or any body else can comment better on it. In any case I ack this patch as it's working for me ;-) > _______________________________________________ > Linux-omap-open-source mailing list > Linux-omap-open-source@linux.omap.com > http://linux.omap.com/mailman/listinfo/linux-omap-open-source -- Best Regards, Felipe Balbi http://felipebalbi.com me@felipebalbi.com ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-19 12:30 [PATCH] - onenand - OMAP3 support - Kconfig update Sameer 2007-11-19 12:39 ` Felipe Balbi @ 2007-11-20 7:32 ` Sameer 2007-11-20 7:47 ` Kyungmin Park 2007-11-22 4:59 ` Sameer 1 sibling, 2 replies; 14+ messages in thread From: Sameer @ 2007-11-20 7:32 UTC (permalink / raw) To: linux-omap-open-source Hi, Please ignore the previous patch. The following patch provides the onenand support for OMAP3. The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and enables omap2_sleep_block() only if CONFIG_PM is defined. Regards, -Sameer --- Index: linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig =================================================================== --- linux-omap-git-20071030.orig/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:28:56.000000000 -0600 +++ linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:29:23.000000000 -0600 @@ -461,7 +461,10 @@ CONFIG_MTD_ONENAND=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y # CONFIG_MTD_ONENAND_GENERIC is not set +CONFIG_MTD_ONENAND_OMAP2=y # CONFIG_MTD_ONENAND_OTP is not set +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set +# CONFIG_MTD_ONENAND_SIM is not set # # UBI - Unsorted block images Index: linux-omap-git-20071030/drivers/mtd/onenand/Kconfig =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:21.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:44.000000000 -0600 @@ -28,10 +28,10 @@ Support for OneNAND flash via platform device driver. config MTD_ONENAND_OMAP2 - tristate "OneNAND on OMAP2 support" - depends on MTD_ONENAND && ARCH_OMAP2 + tristate "OneNAND on OMAP2/OMAP3 support" + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) help - Support for a OneNAND flash device connected to an OMAP2 CPU + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU via the GPMC memory controller. config MTD_ONENAND_OTP Index: linux-omap-git-20071030/drivers/mtd/onenand/omap2.c =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/omap2.c 2007-11-08 12:01:45.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/omap2.c 2007-11-08 12:02:08.000000000 -0600 @@ -39,7 +39,6 @@ #include <asm/arch/onenand.h> #include <asm/arch/gpio.h> #include <asm/arch/gpmc.h> -#include <asm/arch/pm.h> #include <linux/dma-mapping.h> #include <asm/dma-mapping.h> @@ -47,6 +46,13 @@ #include <asm/arch/board.h> +#ifdef CONFIG_PM +#include <asm/arch/pm.h> +#else +#define omap2_block_sleep() /* NULL */ +#define omap2_allow_sleep() /* NULL */ +#endif + #define ONENAND_IO_SIZE SZ_128K #define ONENAND_BUFRAM_SIZE (1024 * 5) ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-20 7:32 ` [PATCH: Resending] " Sameer @ 2007-11-20 7:47 ` Kyungmin Park 2007-11-22 4:59 ` Sameer 1 sibling, 0 replies; 14+ messages in thread From: Kyungmin Park @ 2007-11-20 7:47 UTC (permalink / raw) To: 'Sameer', linux-omap-open-source Hi, That's the reason not yet merged the mtd tree. The vanilla kernel doesn't have the omap2_sleep_block(). I'm not sure it's only dependent on CONFIG_PM. Thank you, Kyungmin Park -----Original Message----- From: linux-omap-open-source-bounces+kyungmin.park=samsung.com@linux.omap.com [mailto:linux-omap-open-source-bounces+kyungmin.park=samsung.com@linux.omap. com] On Behalf Of Sameer Sent: Tuesday, November 20, 2007 4:32 PM To: linux-omap-open-source@linux.omap.com Subject: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update Hi, Please ignore the previous patch. The following patch provides the onenand support for OMAP3. The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and enables omap2_sleep_block() only if CONFIG_PM is defined. Regards, -Sameer --- Index: linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig =================================================================== --- linux-omap-git-20071030.orig/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:28:56.000000000 -0600 +++ linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:29:23.000000000 -0600 @@ -461,7 +461,10 @@ CONFIG_MTD_ONENAND=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y # CONFIG_MTD_ONENAND_GENERIC is not set +CONFIG_MTD_ONENAND_OMAP2=y # CONFIG_MTD_ONENAND_OTP is not set +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set +# CONFIG_MTD_ONENAND_SIM is not set # # UBI - Unsorted block images Index: linux-omap-git-20071030/drivers/mtd/onenand/Kconfig =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:21.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:44.000000000 -0600 @@ -28,10 +28,10 @@ Support for OneNAND flash via platform device driver. config MTD_ONENAND_OMAP2 - tristate "OneNAND on OMAP2 support" - depends on MTD_ONENAND && ARCH_OMAP2 + tristate "OneNAND on OMAP2/OMAP3 support" + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) help - Support for a OneNAND flash device connected to an OMAP2 CPU + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU via the GPMC memory controller. config MTD_ONENAND_OTP Index: linux-omap-git-20071030/drivers/mtd/onenand/omap2.c =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/omap2.c 2007-11-08 12:01:45.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/omap2.c 2007-11-08 12:02:08.000000000 -0600 @@ -39,7 +39,6 @@ #include <asm/arch/onenand.h> #include <asm/arch/gpio.h> #include <asm/arch/gpmc.h> -#include <asm/arch/pm.h> #include <linux/dma-mapping.h> #include <asm/dma-mapping.h> @@ -47,6 +46,13 @@ #include <asm/arch/board.h> +#ifdef CONFIG_PM +#include <asm/arch/pm.h> +#else +#define omap2_block_sleep() /* NULL */ +#define omap2_allow_sleep() /* NULL */ +#endif + #define ONENAND_IO_SIZE SZ_128K #define ONENAND_BUFRAM_SIZE (1024 * 5) _______________________________________________ Linux-omap-open-source mailing list Linux-omap-open-source@linux.omap.com http://linux.omap.com/mailman/listinfo/linux-omap-open-source ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-20 7:32 ` [PATCH: Resending] " Sameer 2007-11-20 7:47 ` Kyungmin Park @ 2007-11-22 4:59 ` Sameer 2007-11-23 21:28 ` Tony Lindgren 1 sibling, 1 reply; 14+ messages in thread From: Sameer @ 2007-11-22 4:59 UTC (permalink / raw) To: linux-omap-open-source Hi, Please ignore the previous patch. The following patch provides the onenand support for OMAP3. The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and enables omap2_sleep_block() only if CONFIG_PM is defined. Also adding the signed off by line which was missed in the previous mail. Regards, -Sameer Signed-off-by: Nishant Kamat <nskamat@ti.com> Signed-off-by: Sameer <sameersu@ti.com> --- Index: linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig =================================================================== --- linux-omap-git-20071030.orig/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:28:56.000000000 -0600 +++ linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig 2007-11-08 11:29:23.000000000 -0600 @@ -461,7 +461,10 @@ CONFIG_MTD_ONENAND=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y # CONFIG_MTD_ONENAND_GENERIC is not set +CONFIG_MTD_ONENAND_OMAP2=y # CONFIG_MTD_ONENAND_OTP is not set +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set +# CONFIG_MTD_ONENAND_SIM is not set # # UBI - Unsorted block images Index: linux-omap-git-20071030/drivers/mtd/onenand/Kconfig =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:21.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/Kconfig 2007-11-08 11:25:44.000000000 -0600 @@ -28,10 +28,10 @@ Support for OneNAND flash via platform device driver. config MTD_ONENAND_OMAP2 - tristate "OneNAND on OMAP2 support" - depends on MTD_ONENAND && ARCH_OMAP2 + tristate "OneNAND on OMAP2/OMAP3 support" + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) help - Support for a OneNAND flash device connected to an OMAP2 CPU + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU via the GPMC memory controller. config MTD_ONENAND_OTP Index: linux-omap-git-20071030/drivers/mtd/onenand/omap2.c =================================================================== --- linux-omap-git-20071030.orig/drivers/mtd/onenand/omap2.c 2007-11-08 12:01:45.000000000 -0600 +++ linux-omap-git-20071030/drivers/mtd/onenand/omap2.c 2007-11-08 12:02:08.000000000 -0600 @@ -39,7 +39,6 @@ #include <asm/arch/onenand.h> #include <asm/arch/gpio.h> #include <asm/arch/gpmc.h> -#include <asm/arch/pm.h> #include <linux/dma-mapping.h> #include <asm/dma-mapping.h> @@ -47,6 +46,13 @@ #include <asm/arch/board.h> +#ifdef CONFIG_PM +#include <asm/arch/pm.h> +#else +#define omap2_block_sleep() /* NULL */ +#define omap2_allow_sleep() /* NULL */ +#endif + #define ONENAND_IO_SIZE SZ_128K #define ONENAND_BUFRAM_SIZE (1024 * 5) ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-22 4:59 ` Sameer @ 2007-11-23 21:28 ` Tony Lindgren 2007-11-27 11:21 ` Sameer 0 siblings, 1 reply; 14+ messages in thread From: Tony Lindgren @ 2007-11-23 21:28 UTC (permalink / raw) To: Sameer; +Cc: linux-omap-open-source Hi, * Sameer <x0081444@ti.com> [071121 21:00]: > > Hi, > Please ignore the previous patch. > The following patch provides the onenand support for OMAP3. > The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and enables omap2_sleep_block() only if CONFIG_PM > is defined. > Also adding the signed off by line which was missed in the previous mail. > > > Regards, > -Sameer > > Signed-off-by: Nishant Kamat <nskamat@ti.com> > Signed-off-by: Sameer <sameersu@ti.com> > --- > Index: linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig > =================================================================== > --- linux-omap-git-20071030.orig/arch/arm/configs/omap_3430sdp_defconfig > 2007-11-08 11:28:56.000000000 -0600 > +++ linux-omap-git-20071030/arch/arm/configs/omap_3430sdp_defconfig > 2007-11-08 11:29:23.000000000 -0600 > @@ -461,7 +461,10 @@ > CONFIG_MTD_ONENAND=y > CONFIG_MTD_ONENAND_VERIFY_WRITE=y > # CONFIG_MTD_ONENAND_GENERIC is not set > +CONFIG_MTD_ONENAND_OMAP2=y > # CONFIG_MTD_ONENAND_OTP is not set > +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set > +# CONFIG_MTD_ONENAND_SIM is not set > > # > # UBI - Unsorted block images > Index: linux-omap-git-20071030/drivers/mtd/onenand/Kconfig > =================================================================== > --- linux-omap-git-20071030.orig/drivers/mtd/onenand/Kconfig 2007-11-08 > 11:25:21.000000000 -0600 > +++ linux-omap-git-20071030/drivers/mtd/onenand/Kconfig 2007-11-08 > 11:25:44.000000000 -0600 > @@ -28,10 +28,10 @@ > Support for OneNAND flash via platform device driver. > > config MTD_ONENAND_OMAP2 > - tristate "OneNAND on OMAP2 support" > - depends on MTD_ONENAND && ARCH_OMAP2 > + tristate "OneNAND on OMAP2/OMAP3 support" > + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) > help > - Support for a OneNAND flash device connected to an OMAP2 CPU > + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU > via the GPMC memory controller. > > config MTD_ONENAND_OTP > Index: linux-omap-git-20071030/drivers/mtd/onenand/omap2.c > =================================================================== > --- linux-omap-git-20071030.orig/drivers/mtd/onenand/omap2.c 2007-11-08 > 12:01:45.000000000 -0600 > +++ linux-omap-git-20071030/drivers/mtd/onenand/omap2.c 2007-11-08 > 12:02:08.000000000 -0600 > @@ -39,7 +39,6 @@ > #include <asm/arch/onenand.h> > #include <asm/arch/gpio.h> > #include <asm/arch/gpmc.h> > -#include <asm/arch/pm.h> > > #include <linux/dma-mapping.h> > #include <asm/dma-mapping.h> > @@ -47,6 +46,13 @@ > > #include <asm/arch/board.h> > > +#ifdef CONFIG_PM > +#include <asm/arch/pm.h> > +#else > +#define omap2_block_sleep() /* NULL */ > +#define omap2_allow_sleep() /* NULL */ > +#endif > + > #define ONENAND_IO_SIZE SZ_128K > #define ONENAND_BUFRAM_SIZE (1024 * 5) > How about defining these in asm/arch/pm.h instead? Tony ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-23 21:28 ` Tony Lindgren @ 2007-11-27 11:21 ` Sameer 2007-11-27 12:55 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Sameer @ 2007-11-27 11:21 UTC (permalink / raw) To: linux-omap-open-source, 'Tony Lindgren' Hi, Please ignore the previous patch. The following patch provides the onenand support for OMAP3. The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and redeclaring the omap2_sleep_block(), omap2_allow_sleep() according to CONFIG_PM defination in pm.h according to Tony's recommendation. Regards, -Sameer Signed-off-by: Nishant Kamat <nskamat@ti.com> Signed-off-by: Sameer <sameersu@ti.com> --- --- arch/arm/configs/omap_3430sdp_defconfig | 3 +++ drivers/mtd/onenand/Kconfig | 6 +++--- include/asm-arm/arch-omap/pm.h | 8 +++++++- 3 files changed, 13 insertions(+), 4 deletions(-) Index: linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig =================================================================== --- linux-omap-git.orig/arch/arm/configs/omap_3430sdp_defconfig +++ linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig @@ -461,7 +461,10 @@ CONFIG_MTD_OMAP_NOR=y CONFIG_MTD_ONENAND=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y # CONFIG_MTD_ONENAND_GENERIC is not set +CONFIG_MTD_ONENAND_OMAP2=y # CONFIG_MTD_ONENAND_OTP is not set +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set +# CONFIG_MTD_ONENAND_SIM is not set # # UBI - Unsorted block images Index: linux-omap-git/drivers/mtd/onenand/Kconfig =================================================================== --- linux-omap-git.orig/drivers/mtd/onenand/Kconfig +++ linux-omap-git/drivers/mtd/onenand/Kconfig @@ -28,10 +28,10 @@ config MTD_ONENAND_GENERIC Support for OneNAND flash via platform device driver. config MTD_ONENAND_OMAP2 - tristate "OneNAND on OMAP2 support" - depends on MTD_ONENAND && ARCH_OMAP2 + tristate "OneNAND on OMAP2/OMAP3 support" + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) help - Support for a OneNAND flash device connected to an OMAP2 CPU + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU via the GPMC memory controller. config MTD_ONENAND_OTP Index: linux-omap-git/include/asm-arm/arch-omap/pm.h =================================================================== --- linux-omap-git.orig/include/asm-arm/arch-omap/pm.h +++ linux-omap-git/include/asm-arm/arch-omap/pm.h @@ -107,7 +107,8 @@ #if !defined(CONFIG_ARCH_OMAP730) && \ !defined(CONFIG_ARCH_OMAP15XX) && \ !defined(CONFIG_ARCH_OMAP16XX) && \ - !defined(CONFIG_ARCH_OMAP24XX) + !defined(CONFIG_ARCH_OMAP24XX) && \ + !defined(CONFIG_ARCH_OMAP34XX) #error "Power management for this processor not implemented yet" #endif @@ -134,8 +135,13 @@ void clk_deny_idle(struct clk *clk); extern void omap_pm_idle(void); extern void omap_pm_suspend(void); +#ifdef CONFIG_PM extern void omap2_block_sleep(void); extern void omap2_allow_sleep(void); +#else +#define omap2_block_sleep() /* NULL */ +#define omap2_allow_sleep() /* NULL */ +#endif extern void omap730_cpu_suspend(unsigned short, unsigned short); extern void omap1510_cpu_suspend(unsigned short, unsigned short); extern void omap1611_cpu_suspend(unsigned short, unsigned short); ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-27 11:21 ` Sameer @ 2007-11-27 12:55 ` Felipe Balbi 2007-11-28 5:50 ` Sameer 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2007-11-27 12:55 UTC (permalink / raw) To: ext Sameer; +Cc: linux-omap-open-source On Tue, Nov 27, 2007 at 04:51:24PM +0530, ext Sameer wrote: snip > Index: linux-omap-git/include/asm-arm/arch-omap/pm.h > =================================================================== > --- linux-omap-git.orig/include/asm-arm/arch-omap/pm.h > +++ linux-omap-git/include/asm-arm/arch-omap/pm.h > @@ -107,7 +107,8 @@ > #if !defined(CONFIG_ARCH_OMAP730) && \ > !defined(CONFIG_ARCH_OMAP15XX) && \ > !defined(CONFIG_ARCH_OMAP16XX) && \ > - !defined(CONFIG_ARCH_OMAP24XX) > + !defined(CONFIG_ARCH_OMAP24XX) && \ > + !defined(CONFIG_ARCH_OMAP34XX) > #error "Power management for this processor not implemented yet" > #endif > > @@ -134,8 +135,13 @@ void clk_deny_idle(struct clk *clk); > > extern void omap_pm_idle(void); > extern void omap_pm_suspend(void); > +#ifdef CONFIG_PM > extern void omap2_block_sleep(void); > extern void omap2_allow_sleep(void); > +#else > +#define omap2_block_sleep() /* NULL */ > +#define omap2_allow_sleep() /* NULL */ I'd prefer: #else static inline void omap2_block_sleep(void) { } static inline void omap2_allow_sleep(void) { } #endif but it looks ok. > +#endif > extern void omap730_cpu_suspend(unsigned short, unsigned short); > extern void omap1510_cpu_suspend(unsigned short, unsigned short); > extern void omap1611_cpu_suspend(unsigned short, unsigned short); > > _______________________________________________ > Linux-omap-open-source mailing list > Linux-omap-open-source@linux.omap.com > http://linux.omap.com/mailman/listinfo/linux-omap-open-source -- Best Regards, Felipe Balbi felipe.lima@indt.org.br +55 92 2126-1003 INdT - OSMRC - Manaus Core Team ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-27 12:55 ` Felipe Balbi @ 2007-11-28 5:50 ` Sameer 2007-11-28 12:41 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Sameer @ 2007-11-28 5:50 UTC (permalink / raw) To: linux-omap-open-source; +Cc: ext-felipe.lima Hi, Please ignore the previous patch. The following patch provides the onenand support for OMAP3. The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and redeclaring the omap2_sleep_block(), omap2_allow_sleep() according to CONFIG_PM defination in pm.h according to Felipe Balbi's comments. Regards, -Sameer Signed-off-by: Nishant Kamat <nskamat@ti.com> Signed-off-by: Sameer <sameersu@ti.com> --- --- arch/arm/configs/omap_3430sdp_defconfig | 3 +++ drivers/mtd/onenand/Kconfig | 6 +++--- include/asm-arm/arch-omap/pm.h | 8 +++++++- 3 files changed, 13 insertions(+), 4 deletions(-) Index: linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig =================================================================== --- linux-omap-git.orig/arch/arm/configs/omap_3430sdp_defconfig +++ linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig @@ -461,7 +461,10 @@ CONFIG_MTD_OMAP_NOR=y CONFIG_MTD_ONENAND=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y # CONFIG_MTD_ONENAND_GENERIC is not set +CONFIG_MTD_ONENAND_OMAP2=y # CONFIG_MTD_ONENAND_OTP is not set +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set +# CONFIG_MTD_ONENAND_SIM is not set # # UBI - Unsorted block images Index: linux-omap-git/drivers/mtd/onenand/Kconfig =================================================================== --- linux-omap-git.orig/drivers/mtd/onenand/Kconfig +++ linux-omap-git/drivers/mtd/onenand/Kconfig @@ -28,10 +28,10 @@ config MTD_ONENAND_GENERIC Support for OneNAND flash via platform device driver. config MTD_ONENAND_OMAP2 - tristate "OneNAND on OMAP2 support" - depends on MTD_ONENAND && ARCH_OMAP2 + tristate "OneNAND on OMAP2/OMAP3 support" + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) help - Support for a OneNAND flash device connected to an OMAP2 CPU + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU via the GPMC memory controller. config MTD_ONENAND_OTP Index: linux-omap-git/include/asm-arm/arch-omap/pm.h =================================================================== --- linux-omap-git.orig/include/asm-arm/arch-omap/pm.h +++ linux-omap-git/include/asm-arm/arch-omap/pm.h @@ -107,7 +107,8 @@ #if !defined(CONFIG_ARCH_OMAP730) && \ !defined(CONFIG_ARCH_OMAP15XX) && \ !defined(CONFIG_ARCH_OMAP16XX) && \ - !defined(CONFIG_ARCH_OMAP24XX) + !defined(CONFIG_ARCH_OMAP24XX) && \ + !defined(CONFIG_ARCH_OMAP34XX) #error "Power management for this processor not implemented yet" #endif @@ -134,8 +135,13 @@ void clk_deny_idle(struct clk *clk); extern void omap_pm_idle(void); extern void omap_pm_suspend(void); +#ifdef CONFIG_PM extern void omap2_block_sleep(void); extern void omap2_allow_sleep(void); +#else +static inline void omap2_block_sleep(void) { } +static inline void omap2_allow_sleep(void) { } +#endif extern void omap730_cpu_suspend(unsigned short, unsigned short); extern void omap1510_cpu_suspend(unsigned short, unsigned short); extern void omap1610_cpu_suspend(unsigned short, unsigned short); ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-28 5:50 ` Sameer @ 2007-11-28 12:41 ` Felipe Balbi 2007-11-28 21:09 ` Tony Lindgren 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2007-11-28 12:41 UTC (permalink / raw) To: ext Sameer; +Cc: ext-felipe.lima, linux-omap-open-source On Wed, Nov 28, 2007 at 11:20:38AM +0530, ext Sameer wrote: > Hi, > Please ignore the previous patch. > The following patch provides the onenand support for OMAP3. > The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and redeclaring the omap2_sleep_block(), omap2_allow_sleep() according to CONFIG_PM defination in pm.h according to Felipe Balbi's comments. > > Regards, > -Sameer > > Signed-off-by: Nishant Kamat <nskamat@ti.com> > Signed-off-by: Sameer <sameersu@ti.com> Acked-by: Felipe Balbi <felipe.lima@indt.org.br> > --- > --- > arch/arm/configs/omap_3430sdp_defconfig | 3 +++ > drivers/mtd/onenand/Kconfig | 6 +++--- > include/asm-arm/arch-omap/pm.h | 8 +++++++- > 3 files changed, 13 insertions(+), 4 deletions(-) > > Index: linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig > =================================================================== > --- linux-omap-git.orig/arch/arm/configs/omap_3430sdp_defconfig > +++ linux-omap-git/arch/arm/configs/omap_3430sdp_defconfig > @@ -461,7 +461,10 @@ CONFIG_MTD_OMAP_NOR=y > CONFIG_MTD_ONENAND=y > CONFIG_MTD_ONENAND_VERIFY_WRITE=y > # CONFIG_MTD_ONENAND_GENERIC is not set > +CONFIG_MTD_ONENAND_OMAP2=y > # CONFIG_MTD_ONENAND_OTP is not set > +# CONFIG_MTD_ONENAND_2X_PROGRAM is not set > +# CONFIG_MTD_ONENAND_SIM is not set > > # > # UBI - Unsorted block images > Index: linux-omap-git/drivers/mtd/onenand/Kconfig > =================================================================== > --- linux-omap-git.orig/drivers/mtd/onenand/Kconfig > +++ linux-omap-git/drivers/mtd/onenand/Kconfig > @@ -28,10 +28,10 @@ config MTD_ONENAND_GENERIC > Support for OneNAND flash via platform device driver. > > config MTD_ONENAND_OMAP2 > - tristate "OneNAND on OMAP2 support" > - depends on MTD_ONENAND && ARCH_OMAP2 > + tristate "OneNAND on OMAP2/OMAP3 support" > + depends on MTD_ONENAND && (ARCH_OMAP2 || ARCH_OMAP3) > help > - Support for a OneNAND flash device connected to an OMAP2 CPU > + Support for a OneNAND flash device connected to an OMAP2/OMAP3 CPU > via the GPMC memory controller. > > config MTD_ONENAND_OTP > Index: linux-omap-git/include/asm-arm/arch-omap/pm.h > =================================================================== > --- linux-omap-git.orig/include/asm-arm/arch-omap/pm.h > +++ linux-omap-git/include/asm-arm/arch-omap/pm.h > @@ -107,7 +107,8 @@ > #if !defined(CONFIG_ARCH_OMAP730) && \ > !defined(CONFIG_ARCH_OMAP15XX) && \ > !defined(CONFIG_ARCH_OMAP16XX) && \ > - !defined(CONFIG_ARCH_OMAP24XX) > + !defined(CONFIG_ARCH_OMAP24XX) && \ > + !defined(CONFIG_ARCH_OMAP34XX) > #error "Power management for this processor not implemented yet" > #endif > > @@ -134,8 +135,13 @@ void clk_deny_idle(struct clk *clk); > > extern void omap_pm_idle(void); > extern void omap_pm_suspend(void); > +#ifdef CONFIG_PM > extern void omap2_block_sleep(void); > extern void omap2_allow_sleep(void); > +#else > +static inline void omap2_block_sleep(void) { } > +static inline void omap2_allow_sleep(void) { } > +#endif > extern void omap730_cpu_suspend(unsigned short, unsigned short); > extern void omap1510_cpu_suspend(unsigned short, unsigned short); > extern void omap1610_cpu_suspend(unsigned short, unsigned short); -- Best Regards, Felipe Balbi felipe.lima@indt.org.br +55 92 2126-1003 INdT - OSMRC - Manaus Core Team ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-28 12:41 ` Felipe Balbi @ 2007-11-28 21:09 ` Tony Lindgren 2007-12-05 21:15 ` Kamat, Nishant 0 siblings, 1 reply; 14+ messages in thread From: Tony Lindgren @ 2007-11-28 21:09 UTC (permalink / raw) To: Felipe Balbi; +Cc: linux-omap-open-source, ext Sameer * Felipe Balbi <ext-felipe.lima@nokia.com> [071128 08:56]: > On Wed, Nov 28, 2007 at 11:20:38AM +0530, ext Sameer wrote: > > Hi, > > Please ignore the previous patch. > > The following patch provides the onenand support for OMAP3. > > The patch enables the onenand in def_config file, enable onenand Kconfig for OMAP3 and redeclaring the omap2_sleep_block(), omap2_allow_sleep() according to CONFIG_PM defination in pm.h according to Felipe Balbi's comments. Pushing today. Tony ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-11-28 21:09 ` Tony Lindgren @ 2007-12-05 21:15 ` Kamat, Nishant 2007-12-05 23:08 ` Tony Lindgren 0 siblings, 1 reply; 14+ messages in thread From: Kamat, Nishant @ 2007-12-05 21:15 UTC (permalink / raw) To: Tony Lindgren, Felipe Balbi; +Cc: linux-omap-open-source, ext Sameer Hi Tony, > -----Original Message----- > From: Tony Lindgren > Sent: Wednesday, November 28, 2007 3:09 PM > > * Felipe Balbi <ext-felipe.lima@nokia.com> [071128 08:56]: > > On Wed, Nov 28, 2007 at 11:20:38AM +0530, ext Sameer wrote: > > > Hi, > > > Please ignore the previous patch. > > > The following patch provides the onenand support for OMAP3. > > > The patch enables the onenand in def_config file, enable > onenand Kconfig for OMAP3 and redeclaring the > omap2_sleep_block(), omap2_allow_sleep() according to > CONFIG_PM defination in pm.h according to Felipe Balbi's comments. > > Pushing today. > > Tony Seems like this patch is not merged yet.. Regards, Nishant ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-12-05 21:15 ` Kamat, Nishant @ 2007-12-05 23:08 ` Tony Lindgren 2007-12-05 23:14 ` Kamat, Nishant 0 siblings, 1 reply; 14+ messages in thread From: Tony Lindgren @ 2007-12-05 23:08 UTC (permalink / raw) To: Kamat, Nishant; +Cc: Felipe Balbi, linux-omap-open-source, ext Sameer * Kamat, Nishant <nskamat@ti.com> [071205 13:18]: > Hi Tony, > > > -----Original Message----- > > From: Tony Lindgren > > Sent: Wednesday, November 28, 2007 3:09 PM > > > > * Felipe Balbi <ext-felipe.lima@nokia.com> [071128 08:56]: > > > On Wed, Nov 28, 2007 at 11:20:38AM +0530, ext Sameer wrote: > > > > Hi, > > > > Please ignore the previous patch. > > > > The following patch provides the onenand support for OMAP3. > > > > The patch enables the onenand in def_config file, enable > > onenand Kconfig for OMAP3 and redeclaring the > > omap2_sleep_block(), omap2_allow_sleep() according to > > CONFIG_PM defination in pm.h according to Felipe Balbi's comments. > > > > Pushing today. > > > > Tony > > Seems like this patch is not merged yet.. Sorry, I must have forgotten to do git-am after refreshing it as a quilt patch... Pushed now, can you please check? Tony ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH: Resending] - onenand - OMAP3 support - Kconfig update 2007-12-05 23:08 ` Tony Lindgren @ 2007-12-05 23:14 ` Kamat, Nishant 0 siblings, 0 replies; 14+ messages in thread From: Kamat, Nishant @ 2007-12-05 23:14 UTC (permalink / raw) To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap-open-source, ext Sameer Tony, > -----Original Message----- > From: Tony Lindgren [mailto:tony@atomide.com] > > > Pushing today. > > > > > > Tony > > > > Seems like this patch is not merged yet.. > > Sorry, I must have forgotten to do git-am after refreshing it as a > quilt patch... Pushed now, can you please check? > > Tony > Yes, its there now. Thanks! Regards, Nishant ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2007-12-05 23:14 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-11-19 12:30 [PATCH] - onenand - OMAP3 support - Kconfig update Sameer 2007-11-19 12:39 ` Felipe Balbi 2007-11-20 7:32 ` [PATCH: Resending] " Sameer 2007-11-20 7:47 ` Kyungmin Park 2007-11-22 4:59 ` Sameer 2007-11-23 21:28 ` Tony Lindgren 2007-11-27 11:21 ` Sameer 2007-11-27 12:55 ` Felipe Balbi 2007-11-28 5:50 ` Sameer 2007-11-28 12:41 ` Felipe Balbi 2007-11-28 21:09 ` Tony Lindgren 2007-12-05 21:15 ` Kamat, Nishant 2007-12-05 23:08 ` Tony Lindgren 2007-12-05 23:14 ` Kamat, Nishant
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox