Re: [PATCH] OMAP: MUSB: MUSB fix to work as Module for 24xx/Davinci

[David Brownell <david-b@pacbell.net>]

On Tuesday 20 November 2007, Pandita, Vikram wrote:
> From: Vikram Pandita <vikram.pandita@ti.com>
> 
> Fix to get MUSB working as Module for 2430 and Davinci platform

I don't understand the point of this patch.  It certainly used to
work as a module on DaVinci ... as recently as a few months ago.

And this particular register is at a fixed location, not subject
to the usual register banking stuff.  Kicking in that banking
logic would be incorrect.


> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
> 
> Index: linux-omap/drivers/usb/musb/musb_core.c
> ===================================================================
> --- linux-omap.orig/drivers/usb/musb/musb_core.c	2007-11-20 14:24:03.000000000 +0530
> +++ linux-omap/drivers/usb/musb/musb_core.c	2007-11-20 14:26:22.000000000 +0530
> @@ -1336,7 +1336,7 @@
>  
>  	/* log core options (read using indexed model) */
>  	musb_ep_select(mbase, 0);
> -	reg = musb_readb(mbase, 0x10 + MUSB_CONFIGDATA);
> +	reg = musb_readb(mbase, MUSB_EP_OFFSET(0, MUSB_CONFIGDATA));
>  
>  	strcpy(aInfo, (reg & MUSB_CONFIGDATA_UTMIDW) ? "UTMI-16" : "UTMI-8");
>  	if (reg & MUSB_CONFIGDATA_DYNFIFO) {