From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH] OMAP: MUSB: MUSB fix to work as Module for 24xx/Davinci Date: Thu, 29 Nov 2007 10:22:23 -0800 Message-ID: <200711291022.23735.david-b@pacbell.net> References: <5DF83221BE20114E9C331F665ACBC08003E7FAE3@dbde01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5DF83221BE20114E9C331F665ACBC08003E7FAE3@dbde01.ent.ti.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org On Tuesday 20 November 2007, Pandita, Vikram wrote: > From: Vikram Pandita > > Fix to get MUSB working as Module for 2430 and Davinci platform I don't understand the point of this patch. It certainly used to work as a module on DaVinci ... as recently as a few months ago. And this particular register is at a fixed location, not subject to the usual register banking stuff. Kicking in that banking logic would be incorrect. > Signed-off-by: Vikram Pandita > --- > > Index: linux-omap/drivers/usb/musb/musb_core.c > =================================================================== > --- linux-omap.orig/drivers/usb/musb/musb_core.c 2007-11-20 14:24:03.000000000 +0530 > +++ linux-omap/drivers/usb/musb/musb_core.c 2007-11-20 14:26:22.000000000 +0530 > @@ -1336,7 +1336,7 @@ > > /* log core options (read using indexed model) */ > musb_ep_select(mbase, 0); > - reg = musb_readb(mbase, 0x10 + MUSB_CONFIGDATA); > + reg = musb_readb(mbase, MUSB_EP_OFFSET(0, MUSB_CONFIGDATA)); > > strcpy(aInfo, (reg & MUSB_CONFIGDATA_UTMIDW) ? "UTMI-16" : "UTMI-8"); > if (reg & MUSB_CONFIGDATA_DYNFIFO) {