Re: [RFC/PATCH 1/4] MMC/SD Controller driver for OMAP2430

[Tony Lindgren <tony@atomide.com>]

* Syed Mohammed, Khasim <khasim@ti.com> [071208 07:50]:
> 
> 
> > -----Original Message-----
> > From: linux-omap-open-source-bounces@linux.omap.com [mailto:linux-omap-
> > open-source-bounces@linux.omap.com] On Behalf Of Carlos Aguiar
> > Sent: Friday, December 07, 2007 8:24 PM
> > To: Chikkature Rajashekar, Madhusudhan
> > Cc: linux-omap@vger.kernel.org; linux-omap-open-source@linux.omap.com;
> > linux-arm-kernel@lists.arm.linux.org.uk; 'Pierre Ossman'
> > Subject: Re: [RFC/PATCH 1/4] MMC/SD Controller driver for OMAP2430
> > 
> > ext Madhusudhan Chikkature Rajashekar wrote:
> > > This patch adds MMC controller driver for OMAP2430/3430.
> > >
> > > Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
> > >
> > > ---
> > >  drivers/mmc/host/Makefile     |    9
> > >  drivers/mmc/host/omap_hsmmc.c |  985
> > ++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 993 insertions(+), 1 deletion(-)
> > >
> > > Index: linux-omap-2.6/drivers/mmc/host/omap_hsmmc.c
> > > ===================================================================
> 
> <snip>
> 
> > >
> > Hi Madhu,
> > 
> > I'd rather see this code using multislot structures and omap.c instead
> > of defining a whole new codebase for omap2430 and/or omap3.
> > 
> > BR,
> > 
> > Carlos.
> > 
> > 
> Hi Carlos,
> 
> Thanks for comments.
> 
> I remember we had discussed this before as well, as communicated before the MMC/SD controller on OMAP2430 and 3430 processors is completely different( in Register width, bits, offsets, configuration etc) from OMAP2420 and OMAP1 platforms. It's not recommended to add new MMC controller functionality to existing omap.c. 

Well, this time it actually looks like the MMC controller is
completely different.

> Yes we will definitely use multi-slot structures. We can add multi-slot support after we get formal approval of this code base.

Do you still need to mux between slots if you have three controllers
available? If so, it's worth doing it to start with.

Regards,

Tony