From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Fix chain_a_transfer return value Date: Sat, 15 Dec 2007 16:28:11 -0800 Message-ID: <20071216002811.GE7388@atomide.com> References: <010C7BAE6783F34D9AC336EE5A01A0880506667C@dbde01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <010C7BAE6783F34D9AC336EE5A01A0880506667C@dbde01.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Gadiyar, Anand" Cc: linux-omap@vger.kernel.org, linux-omap-open-source List-Id: linux-omap@vger.kernel.org * Gadiyar, Anand [071214 04:51]: > From: Anand Gadiyar > > This patch changes the return value of omap_dma_chain_a_transfer > to 0 on success instead of the flag 'start_dma', which wasn't really useful > for anything. > > Signed-off-by: Anand Gadiyar > Index: linux-omap-dec10/arch/arm/plat-omap/dma.c > =================================================================== > --- linux-omap-dec10.orig/arch/arm/plat-omap/dma.c 2007-12-10 11:01:38.000000000 +0530 > +++ linux-omap-dec10/arch/arm/plat-omap/dma.c 2007-12-13 16:54:25.378626162 +0530 > @@ -1254,7 +1254,7 @@ > * @param frame_count > * @param callbk_data - channel callback parameter data. > * > - * @return - Success : start_dma status > + * @return - Success : 0 > * Failure: -EINVAL/-EBUSY > */ > int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start, > @@ -1375,7 +1375,7 @@ > dma_chan[lch].flags |= OMAP_DMA_ACTIVE; > } > } > - return start_dma; > + return 0; > } > EXPORT_SYMBOL(omap_dma_chain_a_transfer); Pushing today. Tony