* [PATCH] ARM: OMAP: Remove redundant gpio request at apollon
@ 2007-12-06 1:46 Kyungmin Park
2007-12-17 0:55 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2007-12-06 1:46 UTC (permalink / raw)
To: linux-omap, linux-omap-open-source
The gpio request is done by gpio-keys
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/mach-omap2/board-apollon-keys.c b/arch/arm/mach-omap2/board-apollon-keys.c
index 6b2e551..b6fa4ea 100644
--- a/arch/arm/mach-omap2/board-apollon-keys.c
+++ b/arch/arm/mach-omap2/board-apollon-keys.c
@@ -77,29 +77,17 @@ static void __init apollon_sw_init(void)
{
/* Enter SW - Y11 */
omap_cfg_reg(Y11_242X_GPIO16);
- omap_request_gpio(SW_ENTER_GPIO16);
- omap_set_gpio_direction(SW_ENTER_GPIO16, 1);
/* Up SW - AA12 */
omap_cfg_reg(AA12_242X_GPIO17);
- omap_request_gpio(SW_UP_GPIO17);
- omap_set_gpio_direction(SW_UP_GPIO17, 1);
/* Down SW - AA8 */
omap_cfg_reg(AA8_242X_GPIO58);
- omap_request_gpio(SW_DOWN_GPIO58);
- omap_set_gpio_direction(SW_DOWN_GPIO58, 1);
#ifdef CONFIG_MACH_OMAP_APOLLON_PLUS
/* Left SW - P18 */
omap_cfg_reg(P18_24XX_GPIO95);
- omap_request_gpio(SW_LEFT_GPIO95);
- omap_set_gpio_direction(SW_LEFT_GPIO95, 1);
/* Right SW - M18 */
omap_cfg_reg(M18_24XX_GPIO96);
- omap_request_gpio(SW_RIGHT_GPIO96);
- omap_set_gpio_direction(SW_RIGHT_GPIO96, 1);
/* Esc SW - L14 */
omap_cfg_reg(L14_24XX_GPIO97);
- omap_request_gpio(SW_ESC_GPIO97);
- omap_set_gpio_direction(SW_ESC_GPIO97, 1);
#endif
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: OMAP: Remove redundant gpio request at apollon
2007-12-06 1:46 [PATCH] ARM: OMAP: Remove redundant gpio request at apollon Kyungmin Park
@ 2007-12-17 0:55 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-12-17 0:55 UTC (permalink / raw)
To: Kyungmin Park; +Cc: linux-omap, linux-omap-open-source
* Kyungmin Park <kyungmin.park@samsung.com> [071205 17:46]:
> The gpio request is done by gpio-keys
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/mach-omap2/board-apollon-keys.c b/arch/arm/mach-omap2/board-apollon-keys.c
> index 6b2e551..b6fa4ea 100644
> --- a/arch/arm/mach-omap2/board-apollon-keys.c
> +++ b/arch/arm/mach-omap2/board-apollon-keys.c
> @@ -77,29 +77,17 @@ static void __init apollon_sw_init(void)
> {
> /* Enter SW - Y11 */
> omap_cfg_reg(Y11_242X_GPIO16);
> - omap_request_gpio(SW_ENTER_GPIO16);
> - omap_set_gpio_direction(SW_ENTER_GPIO16, 1);
> /* Up SW - AA12 */
> omap_cfg_reg(AA12_242X_GPIO17);
> - omap_request_gpio(SW_UP_GPIO17);
> - omap_set_gpio_direction(SW_UP_GPIO17, 1);
> /* Down SW - AA8 */
> omap_cfg_reg(AA8_242X_GPIO58);
> - omap_request_gpio(SW_DOWN_GPIO58);
> - omap_set_gpio_direction(SW_DOWN_GPIO58, 1);
> #ifdef CONFIG_MACH_OMAP_APOLLON_PLUS
> /* Left SW - P18 */
> omap_cfg_reg(P18_24XX_GPIO95);
> - omap_request_gpio(SW_LEFT_GPIO95);
> - omap_set_gpio_direction(SW_LEFT_GPIO95, 1);
> /* Right SW - M18 */
> omap_cfg_reg(M18_24XX_GPIO96);
> - omap_request_gpio(SW_RIGHT_GPIO96);
> - omap_set_gpio_direction(SW_RIGHT_GPIO96, 1);
> /* Esc SW - L14 */
> omap_cfg_reg(L14_24XX_GPIO97);
> - omap_request_gpio(SW_ESC_GPIO97);
> - omap_set_gpio_direction(SW_ESC_GPIO97, 1);
> #endif
> }
>
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-17 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-06 1:46 [PATCH] ARM: OMAP: Remove redundant gpio request at apollon Kyungmin Park
2007-12-17 0:55 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox