From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX
Date: Sun, 16 Dec 2007 16:59:30 -0800 [thread overview]
Message-ID: <20071217005929.GW7388@atomide.com> (raw)
In-Reply-To: <87ve7birpi.fsf@vence.hilman.org>
* Kevin Hilman <khilman@mvista.com> [071206 10:50]:
> Kyungmin Park <kyungmin.park@samsung.com> writes:
>
> > Use the correct CONFIG_ARCH_OMAP24XX.
> > It boots on locked SRAM board.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> > index afe8181..6305dc9 100644
> > --- a/arch/arm/plat-omap/sram.c
> > +++ b/arch/arm/plat-omap/sram.c
> > @@ -91,7 +91,7 @@ static int is_sram_locked(void)
> > {
> > int type = 0;
> >
> > -#if defined(CONFIG_ARCH_OMAP242X)
> > +#if defined(CONFIG_ARCH_OMAP24XX)
> > if (cpu_is_omap242x())
> > type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> > OMAP2_DEVICETYPE_MASK);
>
> Shouldn't the cpu_is_omap242x be changed to cpu_is_omap24xx also so
> this works on 2430?
Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
needed here. If not selected, the cpu_is_omapxxxx() functions
are if (0) {} functions and get optimized out.
Tony
prev parent reply other threads:[~2007-12-17 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 1:46 [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX Kyungmin Park
2007-12-06 2:12 ` Paul Walmsley
2007-12-06 18:49 ` Kevin Hilman
2007-12-17 0:59 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217005929.GW7388@atomide.com \
--to=tony@atomide.com \
--cc=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox