* [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX
@ 2007-12-06 1:46 Kyungmin Park
2007-12-06 2:12 ` Paul Walmsley
2007-12-06 18:49 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Kyungmin Park @ 2007-12-06 1:46 UTC (permalink / raw)
To: linux-omap, linux-omap-open-source
Use the correct CONFIG_ARCH_OMAP24XX.
It boots on locked SRAM board.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index afe8181..6305dc9 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -91,7 +91,7 @@ static int is_sram_locked(void)
{
int type = 0;
-#if defined(CONFIG_ARCH_OMAP242X)
+#if defined(CONFIG_ARCH_OMAP24XX)
if (cpu_is_omap242x())
type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
OMAP2_DEVICETYPE_MASK);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX
2007-12-06 1:46 [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX Kyungmin Park
@ 2007-12-06 2:12 ` Paul Walmsley
2007-12-06 18:49 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2007-12-06 2:12 UTC (permalink / raw)
To: Kyungmin Park; +Cc: linux-omap, linux-omap-open-source
On Thu, 6 Dec 2007, Kyungmin Park wrote:
> Use the correct CONFIG_ARCH_OMAP24XX.
> It boots on locked SRAM board.
Acked-by: Paul Walmsley <paul@pwsan.com>
since CONFIG_ARCH_OMAP242X does not exist.
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX
2007-12-06 1:46 [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX Kyungmin Park
2007-12-06 2:12 ` Paul Walmsley
@ 2007-12-06 18:49 ` Kevin Hilman
2007-12-17 0:59 ` Tony Lindgren
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2007-12-06 18:49 UTC (permalink / raw)
To: Kyungmin Park; +Cc: linux-omap, linux-omap-open-source
Kyungmin Park <kyungmin.park@samsung.com> writes:
> Use the correct CONFIG_ARCH_OMAP24XX.
> It boots on locked SRAM board.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index afe8181..6305dc9 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -91,7 +91,7 @@ static int is_sram_locked(void)
> {
> int type = 0;
>
> -#if defined(CONFIG_ARCH_OMAP242X)
> +#if defined(CONFIG_ARCH_OMAP24XX)
> if (cpu_is_omap242x())
> type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> OMAP2_DEVICETYPE_MASK);
Shouldn't the cpu_is_omap242x be changed to cpu_is_omap24xx also so
this works on 2430?
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX
2007-12-06 18:49 ` Kevin Hilman
@ 2007-12-17 0:59 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2007-12-17 0:59 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap, linux-omap-open-source
* Kevin Hilman <khilman@mvista.com> [071206 10:50]:
> Kyungmin Park <kyungmin.park@samsung.com> writes:
>
> > Use the correct CONFIG_ARCH_OMAP24XX.
> > It boots on locked SRAM board.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> > index afe8181..6305dc9 100644
> > --- a/arch/arm/plat-omap/sram.c
> > +++ b/arch/arm/plat-omap/sram.c
> > @@ -91,7 +91,7 @@ static int is_sram_locked(void)
> > {
> > int type = 0;
> >
> > -#if defined(CONFIG_ARCH_OMAP242X)
> > +#if defined(CONFIG_ARCH_OMAP24XX)
> > if (cpu_is_omap242x())
> > type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> > OMAP2_DEVICETYPE_MASK);
>
> Shouldn't the cpu_is_omap242x be changed to cpu_is_omap24xx also so
> this works on 2430?
Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
needed here. If not selected, the cpu_is_omapxxxx() functions
are if (0) {} functions and get optimized out.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-17 0:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-06 1:46 [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX Kyungmin Park
2007-12-06 2:12 ` Paul Walmsley
2007-12-06 18:49 ` Kevin Hilman
2007-12-17 0:59 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox