From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX Date: Sun, 16 Dec 2007 16:59:30 -0800 Message-ID: <20071217005929.GW7388@atomide.com> References: <20071206014651.GA15983@party> <87ve7birpi.fsf@vence.hilman.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87ve7birpi.fsf@vence.hilman.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces+gplao-linux-omap-open-source=gmane.org@linux.omap.com Errors-To: linux-omap-open-source-bounces+gplao-linux-omap-open-source=gmane.org@linux.omap.com To: Kevin Hilman Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Kevin Hilman [071206 10:50]: > Kyungmin Park writes: > > > Use the correct CONFIG_ARCH_OMAP24XX. > > It boots on locked SRAM board. > > > > Signed-off-by: Kyungmin Park > > --- > > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c > > index afe8181..6305dc9 100644 > > --- a/arch/arm/plat-omap/sram.c > > +++ b/arch/arm/plat-omap/sram.c > > @@ -91,7 +91,7 @@ static int is_sram_locked(void) > > { > > int type = 0; > > > > -#if defined(CONFIG_ARCH_OMAP242X) > > +#if defined(CONFIG_ARCH_OMAP24XX) > > if (cpu_is_omap242x()) > > type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) & > > OMAP2_DEVICETYPE_MASK); > > Shouldn't the cpu_is_omap242x be changed to cpu_is_omap24xx also so > this works on 2430? Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be needed here. If not selected, the cpu_is_omapxxxx() functions are if (0) {} functions and get optimized out. Tony