* [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X
@ 2007-12-18 1:33 Kyungmin Park
2007-12-18 2:12 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2007-12-18 1:33 UTC (permalink / raw)
To: linux-omap, linux-omap-open-source
Remove undefined CONFIG_ARCH_OMAP242X.
It boots on locked SRAM board.
Comment from Tony.
Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
needed here. If not selected, the cpu_is_omapxxxx() functions
are if (0) {} functions and get optimized out.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index afe8181..c377cb0 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -91,11 +91,9 @@ static int is_sram_locked(void)
{
int type = 0;
-#if defined(CONFIG_ARCH_OMAP242X)
if (cpu_is_omap242x())
type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
OMAP2_DEVICETYPE_MASK);
-#endif
if (type == GP_DEVICE) {
/* RAMFW: R/W access to all initiators for all qualifier sets */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X
2007-12-18 1:33 [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X Kyungmin Park
@ 2007-12-18 2:12 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-12-18 2:12 UTC (permalink / raw)
To: Kyungmin Park; +Cc: linux-omap, linux-omap-open-source
* Kyungmin Park <kyungmin.park@samsung.com> [071217 17:33]:
> Remove undefined CONFIG_ARCH_OMAP242X.
> It boots on locked SRAM board.
>
> Comment from Tony.
> Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
> needed here. If not selected, the cpu_is_omapxxxx() functions
> are if (0) {} functions and get optimized out.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index afe8181..c377cb0 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -91,11 +91,9 @@ static int is_sram_locked(void)
> {
> int type = 0;
>
> -#if defined(CONFIG_ARCH_OMAP242X)
> if (cpu_is_omap242x())
> type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> OMAP2_DEVICETYPE_MASK);
> -#endif
>
> if (type == GP_DEVICE) {
> /* RAMFW: R/W access to all initiators for all qualifier sets */
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-18 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-18 1:33 [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X Kyungmin Park
2007-12-18 2:12 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox