From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X Date: Mon, 17 Dec 2007 18:12:38 -0800 Message-ID: <20071218021238.GC739@atomide.com> References: <20071218013301.GA19671@party> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20071218013301.GA19671@party> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Kyungmin Park Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Kyungmin Park [071217 17:33]: > Remove undefined CONFIG_ARCH_OMAP242X. > It boots on locked SRAM board. > > Comment from Tony. > Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be > needed here. If not selected, the cpu_is_omapxxxx() functions > are if (0) {} functions and get optimized out. > > Signed-off-by: Kyungmin Park > --- > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c > index afe8181..c377cb0 100644 > --- a/arch/arm/plat-omap/sram.c > +++ b/arch/arm/plat-omap/sram.c > @@ -91,11 +91,9 @@ static int is_sram_locked(void) > { > int type = 0; > > -#if defined(CONFIG_ARCH_OMAP242X) > if (cpu_is_omap242x()) > type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) & > OMAP2_DEVICETYPE_MASK); > -#endif > > if (type == GP_DEVICE) { > /* RAMFW: R/W access to all initiators for all qualifier sets */ Pushing today. Tony