* Russell King - ARM Linux [071231 06:35]: > On Mon, Dec 17, 2007 at 09:56:57PM -0800, Tony Lindgren wrote: > > @@ -339,74 +341,33 @@ static struct spi_board_info palmte_spi_info[] __initdata = { > > }, > > }; > > > > -/* Periodically check for changes on important input pins */ > > -struct timer_list palmte_pin_timer; > > -int prev_power, prev_headphones; > > - > > -static void palmte_pin_handler(unsigned long data) { > > - int power, headphones; > > - > > - power = !omap_get_gpio_datain(PALMTE_DC_GPIO); > > - headphones = omap_get_gpio_datain(PALMTE_HEADPHONES_GPIO); > > - > > - if (power && !prev_power) > > - printk(KERN_INFO "PM: cable connected\n"); > > - else if (!power && prev_power) > > - printk(KERN_INFO "PM: cable disconnected\n"); > > - > > - if (headphones && !prev_headphones) { > > +static void palmte_headphones_detect(void *data, int state) { > > That should be: > > static void palmte_headphones_detect(void *data, int state) > { > Here's the fixed patch. Tony