From: Tony Lindgren <tony@atomide.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: Kevin Hilman <khilman@mvista.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: DMA: fix CLINK mask, clear spurious interrupt
Date: Tue, 11 Mar 2008 17:21:09 +0200 [thread overview]
Message-ID: <20080311152108.GJ7524@atomide.com> (raw)
In-Reply-To: <010C7BAE6783F34D9AC336EE5A01A088057E388F@dbde01.ent.ti.com>
* Gadiyar, Anand <gadiyar@ti.com> [080309 09:30]:
> Ack. Meant to send in this fix this weekend.
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org
> > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Kevin Hilman
> > Sent: Saturday, March 08, 2008 3:19 AM
> > To: linux-omap@vger.kernel.org
> > Cc: Kevin Hilman
> > Subject: [PATCH] ARM: OMAP: DMA: fix CLINK mask, clear
> > spurious interrupt
> >
> > Some bugfixes from the TI CDP kernel.
Pushing today.
Tony
> > Signed-off-by: Kevin Hilman <khilman@mvista.com>
> > ---
> > arch/arm/plat-omap/dma.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> > index 3e94683..008b5dd 100644
> > --- a/arch/arm/plat-omap/dma.c
> > +++ b/arch/arm/plat-omap/dma.c
> > @@ -1020,12 +1020,12 @@ static void create_dma_lch_chain(int
> > lch_head, int lch_queue)
> > }
> >
> > w = OMAP_DMA_CLNK_CTRL_REG(lch_head);
> > - w &= ~(0x0f);
> > + w &= ~(0x1f);
> > w |= lch_queue;
> > OMAP_DMA_CLNK_CTRL_REG(lch_head) = w;
> >
> > w = OMAP_DMA_CLNK_CTRL_REG(lch_queue);
> > - w &= ~(0x0f);
> > + w &= ~(0x1f);
> > w |= (dma_chan[lch_queue].next_linked_ch);
> > OMAP_DMA_CLNK_CTRL_REG(lch_queue) = w;
> > }
> > @@ -1663,6 +1663,7 @@ static int omap2_dma_handle_ch(int ch)
> > if (!status) {
> > if (printk_ratelimit())
> > printk(KERN_WARNING "Spurious DMA IRQ
> > for lch %d\n", ch);
> > + omap_writel(1 << ch, OMAP_DMA4_IRQSTATUS_L0);
> > return 0;
> > }
> > if (unlikely(dma_chan[ch].dev_id == -1)) {
> > --
> > 1.5.4.1.99.gf1785
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-11 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1204926553-6228-1-git-send-email-khilman@mvista.com>
2008-03-09 7:24 ` [PATCH] ARM: OMAP: DMA: fix CLINK mask, clear spurious interrupt Gadiyar, Anand
2008-03-11 15:21 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311152108.GJ7524@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=khilman@mvista.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox