Re: [PATCH] ARM: OMAP: Fix chain_a_transfer return value

[Tony Lindgren <tony@atomide.com>]

* Gadiyar, Anand <gadiyar@ti.com> [080311 08:41]:
> From: Anand Gadiyar <gadiyar@ti.com>
> 
> This patch changes the return value of omap_dma_chain_a_transfer
> to 0 on success instead of the flag 'start_dma', which wasn't really useful
> for anything.
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> This patch seems to have been accidentally reversed by commit
> 6d6baabf174b0543db0873282ec233b5ecc6c083 (ARM: OMAP: Fix DMA comments from RMK)
> 
>  arch/arm/plat-omap/dma.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-omap-2.6/arch/arm/plat-omap/dma.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/dma.c	2008-02-19 11:15:51.000000000 +0530
> +++ linux-omap-2.6/arch/arm/plat-omap/dma.c	2008-03-11 12:04:07.142786661 +0530
> @@ -1248,7 +1248,7 @@ EXPORT_SYMBOL(omap_dma_chain_status);
>   * @param frame_count
>   * @param callbk_data - channel callback parameter data.
>   *
> - * @return  - Success : start_dma status
> + * @return  - Success : 0
>   * 	      Failure: -EINVAL/-EBUSY
>   */
>  int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start,
> @@ -1367,7 +1367,7 @@ int omap_dma_chain_a_transfer(int chain_
>  			dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
>  		}
>  	}
> -	return start_dma;
> +	return 0;
>  }
>  EXPORT_SYMBOL(omap_dma_chain_a_transfer);

Pushing today.

Tony