* [PATCH] ARM: OMAP: Fix chain_a_transfer return value
@ 2007-12-14 12:50 Gadiyar, Anand
2007-12-16 0:28 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Gadiyar, Anand @ 2007-12-14 12:50 UTC (permalink / raw)
To: linux-omap; +Cc: linux-omap-open-source
From: Anand Gadiyar <gadiyar@ti.com>
This patch changes the return value of omap_dma_chain_a_transfer
to 0 on success instead of the flag 'start_dma', which wasn't really useful
for anything.
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Index: linux-omap-dec10/arch/arm/plat-omap/dma.c
===================================================================
--- linux-omap-dec10.orig/arch/arm/plat-omap/dma.c 2007-12-10 11:01:38.000000000 +0530
+++ linux-omap-dec10/arch/arm/plat-omap/dma.c 2007-12-13 16:54:25.378626162 +0530
@@ -1254,7 +1254,7 @@
* @param frame_count
* @param callbk_data - channel callback parameter data.
*
- * @return - Success : start_dma status
+ * @return - Success : 0
* Failure: -EINVAL/-EBUSY
*/
int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start,
@@ -1375,7 +1375,7 @@
dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
}
}
- return start_dma;
+ return 0;
}
EXPORT_SYMBOL(omap_dma_chain_a_transfer);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Fix chain_a_transfer return value
2007-12-14 12:50 Gadiyar, Anand
@ 2007-12-16 0:28 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2007-12-16 0:28 UTC (permalink / raw)
To: Gadiyar, Anand; +Cc: linux-omap, linux-omap-open-source
* Gadiyar, Anand <gadiyar@ti.com> [071214 04:51]:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> This patch changes the return value of omap_dma_chain_a_transfer
> to 0 on success instead of the flag 'start_dma', which wasn't really useful
> for anything.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Index: linux-omap-dec10/arch/arm/plat-omap/dma.c
> ===================================================================
> --- linux-omap-dec10.orig/arch/arm/plat-omap/dma.c 2007-12-10 11:01:38.000000000 +0530
> +++ linux-omap-dec10/arch/arm/plat-omap/dma.c 2007-12-13 16:54:25.378626162 +0530
> @@ -1254,7 +1254,7 @@
> * @param frame_count
> * @param callbk_data - channel callback parameter data.
> *
> - * @return - Success : start_dma status
> + * @return - Success : 0
> * Failure: -EINVAL/-EBUSY
> */
> int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start,
> @@ -1375,7 +1375,7 @@
> dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
> }
> }
> - return start_dma;
> + return 0;
> }
> EXPORT_SYMBOL(omap_dma_chain_a_transfer);
Pushing today.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP: Fix chain_a_transfer return value
@ 2008-03-11 6:40 Gadiyar, Anand
2008-03-11 15:21 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Gadiyar, Anand @ 2008-03-11 6:40 UTC (permalink / raw)
To: linux-omap
From: Anand Gadiyar <gadiyar@ti.com>
This patch changes the return value of omap_dma_chain_a_transfer
to 0 on success instead of the flag 'start_dma', which wasn't really useful
for anything.
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
---
This patch seems to have been accidentally reversed by commit
6d6baabf174b0543db0873282ec233b5ecc6c083 (ARM: OMAP: Fix DMA comments from RMK)
arch/arm/plat-omap/dma.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-omap-2.6/arch/arm/plat-omap/dma.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/dma.c 2008-02-19 11:15:51.000000000 +0530
+++ linux-omap-2.6/arch/arm/plat-omap/dma.c 2008-03-11 12:04:07.142786661 +0530
@@ -1248,7 +1248,7 @@ EXPORT_SYMBOL(omap_dma_chain_status);
* @param frame_count
* @param callbk_data - channel callback parameter data.
*
- * @return - Success : start_dma status
+ * @return - Success : 0
* Failure: -EINVAL/-EBUSY
*/
int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start,
@@ -1367,7 +1367,7 @@ int omap_dma_chain_a_transfer(int chain_
dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
}
}
- return start_dma;
+ return 0;
}
EXPORT_SYMBOL(omap_dma_chain_a_transfer);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Fix chain_a_transfer return value
2008-03-11 6:40 [PATCH] ARM: OMAP: Fix chain_a_transfer return value Gadiyar, Anand
@ 2008-03-11 15:21 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2008-03-11 15:21 UTC (permalink / raw)
To: Gadiyar, Anand; +Cc: linux-omap
* Gadiyar, Anand <gadiyar@ti.com> [080311 08:41]:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> This patch changes the return value of omap_dma_chain_a_transfer
> to 0 on success instead of the flag 'start_dma', which wasn't really useful
> for anything.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> This patch seems to have been accidentally reversed by commit
> 6d6baabf174b0543db0873282ec233b5ecc6c083 (ARM: OMAP: Fix DMA comments from RMK)
>
> arch/arm/plat-omap/dma.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/dma.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/dma.c 2008-02-19 11:15:51.000000000 +0530
> +++ linux-omap-2.6/arch/arm/plat-omap/dma.c 2008-03-11 12:04:07.142786661 +0530
> @@ -1248,7 +1248,7 @@ EXPORT_SYMBOL(omap_dma_chain_status);
> * @param frame_count
> * @param callbk_data - channel callback parameter data.
> *
> - * @return - Success : start_dma status
> + * @return - Success : 0
> * Failure: -EINVAL/-EBUSY
> */
> int omap_dma_chain_a_transfer(int chain_id, int src_start, int dest_start,
> @@ -1367,7 +1367,7 @@ int omap_dma_chain_a_transfer(int chain_
> dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
> }
> }
> - return start_dma;
> + return 0;
> }
> EXPORT_SYMBOL(omap_dma_chain_a_transfer);
Pushing today.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-11 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-11 6:40 [PATCH] ARM: OMAP: Fix chain_a_transfer return value Gadiyar, Anand
2008-03-11 15:21 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2007-12-14 12:50 Gadiyar, Anand
2007-12-16 0:28 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox