From: Tony Lindgren <tony@atomide.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC/PATCH] ARM: OMAP: Add IDCODE revision to system_rev
Date: Thu, 13 Mar 2008 13:48:56 +0200 [thread overview]
Message-ID: <20080313114855.GH11653@atomide.com> (raw)
In-Reply-To: <20080306003550.GA2709@party>
* Kyungmin Park <kyungmin.park@samsung.com> [080306 02:36]:
> In previous kernel there's IDCODE revision. But recently it was removed.
> I hope it want to add this one to distinguish board revision.
>
> Are there another way to combine Silicon revision with IDCODE one?
>
> Any comments are welcome.
Well this is not done currently for 34xx, and two bits are not
enough so we need something better here eventually..
Anyways, pushing today.
Tony
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index a2109c1..dd53ae2 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -168,10 +168,13 @@ void __init omap2_check_revision(void)
> * system_rev & 0xffff0000 -> Omap type (2420/2422/2423/2430/3430)
> * system_rev & 0x0000f000 -> Silicon revision (ES1, ES2 )
> * system_rev & 0x00000700 -> Device Type ( EMU/HS/GP/BAD )
> + * system_rev & 0x000000c0 -> IDCODE revision[6:7]
> * system_rev & 0x0000003f -> sys_boot[0:5]
> */
> /* Embedding the ES revision info in type field */
> system_rev = omap_ids[j].type;
> + /* Also add IDCODE revision info only two lower bits */
> + system_rev |= ((rev & 0x3) << 6);
>
> /* Add in the device type and sys_boot fields (see above) */
> if (cpu_is_omap24xx()) {
parent reply other threads:[~2008-03-13 11:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20080306003550.GA2709@party>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313114855.GH11653@atomide.com \
--to=tony@atomide.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox