From: Seth Forshee <seth.forshee@gmail.com>
To: Carlos Aguiar <carlos.aguiar@indt.org.br>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] PLAT: OMAP: Add device configuration to support second HSMMC slot on OMAP 2430 and 3430 boards.
Date: Thu, 20 Mar 2008 19:44:02 -0500 [thread overview]
Message-ID: <20080321004401.GA8667@ubuntu-workstation> (raw)
In-Reply-To: <47E273BD.9080705@indt.org.br>
On Thu, Mar 20, 2008 at 10:25:01AM -0400, Carlos Aguiar wrote:
> if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> - if (mmc->enabled)
> + mmc = &mmc_conf->mmc[1];
> + if (mmc->enabled) {
> (void) platform_device_register(&mmc_omap_device1);
> + (void) platform_device_register(&mmc_omap_device2);
> + }
Shouldn't you only register each device if enabled in the corresponding
configuration, i.e.:
if (mmc_conf->mmc[1].enabled)
(void) platform_device_register(&mmc_omap_device1);
if (mmc_conf->mmc[2].enabled)
(void) platform_device_register(&mmc_omap_device2);
It looks to me like, with this patch applied, no MMC devices will be
registered with the current board-2430sdp.c.
Otherwise I'd say this looks like an improvement over what I worked up (I
overlooked the section quoted above, which would have saved me the trouble of
working out the muxings).
Cheers,
Seth
next prev parent reply other threads:[~2008-03-21 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:25 [PATCH 1/1] PLAT: OMAP: Add device configuration to support second HSMMC slot on OMAP 2430 and 3430 boards Carlos Aguiar
2008-03-21 0:44 ` Seth Forshee [this message]
2008-03-24 2:10 ` Seth Forshee
2008-03-28 10:31 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2008-03-31 12:52 Carlos Aguiar
2008-03-31 20:06 Carlos Aguiar
2008-03-31 20:52 ` Francisco Alecrim
2008-04-02 7:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321004401.GA8667@ubuntu-workstation \
--to=seth.forshee@gmail.com \
--cc=carlos.aguiar@indt.org.br \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox