* Russell King - ARM Linux [080321 14:05]: > On Thu, Mar 20, 2008 at 11:25:52AM -0700, Kevin Hilman wrote: > > Russell King - ARM Linux writes: > > > > > On Mon, Mar 17, 2008 at 11:42:36AM +0200, Tony Lindgren wrote: > > >> This patch fixes timer32k for clockevents and syncs it with > > >> linux-omap tree. > > >> > > >> Signed-off-by: Tony Lindgren > > >> --- > > >> arch/arm/mach-omap1/timer32k.c | 20 ++++++++++++++------ > > >> 1 files changed, 14 insertions(+), 6 deletions(-) > > >> > > >>... > > >> @@ -126,9 +131,9 @@ static void omap_32k_timer_set_mode(enum clock_event_mode mode, > > >> > > >> switch (mode) { > > >> case CLOCK_EVT_MODE_PERIODIC: > > >> + case CLOCK_EVT_MODE_ONESHOT: > > >> omap_32k_timer_start(OMAP_32K_TIMER_TICK_PERIOD); > > >> break; > > >> - case CLOCK_EVT_MODE_ONESHOT: > > > > > > I didn't think an event was supposed to be programmed to fire when one > > > shot mode is selected - from the other implementations, it appears that > > > the timer should be disabled until set_next_event() has been called. > > > > That is correct. The 'start' should only be happening for the > > periodic mode. This following change should be done. > > Or just omit the bogus change from the original patch. OK, here's the fixed patch. Tony