* Unnecessary line in omapfb_main.c
@ 2008-03-25 9:10 arun c
2008-03-28 10:30 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: arun c @ 2008-03-25 9:10 UTC (permalink / raw)
To: linux-omap
Hi all,
While grepping through the sources i found one unnecessary line in
omapfb_main.c
The patch is pasted below.
diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c
index f66b81a..07eb3f0 100644
--- a/drivers/video/omap/omapfb_main.c
+++ b/drivers/video/omap/omapfb_main.c
@@ -559,7 +559,6 @@ static int set_fb_var(struct fb_info *fbi,
var->xoffset = var->xres_virtual - var->xres;
if (var->yres + var->yoffset > var->yres_virtual)
var->yoffset = var->yres_virtual - var->yres;
- line_size = var->xres * bpp / 8;
if (plane->color_mode == OMAPFB_COLOR_RGB444) {
var->red.offset = 8; var->red.length = 4;
Regards,
Arun c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Unnecessary line in omapfb_main.c
2008-03-25 9:10 Unnecessary line in omapfb_main.c arun c
@ 2008-03-28 10:30 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-03-28 10:30 UTC (permalink / raw)
To: arun c; +Cc: linux-omap
* arun c <arunedarath@mistralsolutions.com> [080325 11:11]:
> Hi all,
>
> While grepping through the sources i found one unnecessary line in
> omapfb_main.c
>
> The patch is pasted below.
>
> diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c
> index f66b81a..07eb3f0 100644
> --- a/drivers/video/omap/omapfb_main.c
> +++ b/drivers/video/omap/omapfb_main.c
> @@ -559,7 +559,6 @@ static int set_fb_var(struct fb_info *fbi,
> var->xoffset = var->xres_virtual - var->xres;
> if (var->yres + var->yoffset > var->yres_virtual)
> var->yoffset = var->yres_virtual - var->yres;
> - line_size = var->xres * bpp / 8;
>
> if (plane->color_mode == OMAPFB_COLOR_RGB444) {
> var->red.offset = 8; var->red.length = 4;
Indeed looks like dead code as line_size is not used after that line
:) Can you please send the patch with proper Signed-off-by?
Thanks,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-28 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25 9:10 Unnecessary line in omapfb_main.c arun c
2008-03-28 10:30 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox