From: Tony Lindgren <tony@atomide.com>
To: Carlos Aguiar <carlos.aguiar@indt.org.br>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] PLAT: OMAP: Add device configuration to support second HSMMC slot on OMAP 2430 and 3430 boards.
Date: Fri, 28 Mar 2008 12:31:39 +0200 [thread overview]
Message-ID: <20080328103138.GU24896@atomide.com> (raw)
In-Reply-To: <20080324021045.GA19892@ubuntu-workstation>
* Seth Forshee <seth.forshee@gmail.com> [080324 04:12]:
> On Thu, Mar 20, 2008 at 07:44:02PM -0500, Seth Forshee wrote:
> > Shouldn't you only register each device if enabled in the corresponding
> > configuration, i.e.:
> >
> > if (mmc_conf->mmc[1].enabled)
> > (void) platform_device_register(&mmc_omap_device1);
> > if (mmc_conf->mmc[2].enabled)
> > (void) platform_device_register(&mmc_omap_device2);
>
> Of course that should be 0 and 1, not 1 and 2.
This sounds like a valid comment to me, so not pushing.
Tony
next prev parent reply other threads:[~2008-03-28 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:25 [PATCH 1/1] PLAT: OMAP: Add device configuration to support second HSMMC slot on OMAP 2430 and 3430 boards Carlos Aguiar
2008-03-21 0:44 ` Seth Forshee
2008-03-24 2:10 ` Seth Forshee
2008-03-28 10:31 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-31 12:52 Carlos Aguiar
2008-03-31 20:06 Carlos Aguiar
2008-03-31 20:52 ` Francisco Alecrim
2008-04-02 7:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328103138.GU24896@atomide.com \
--to=tony@atomide.com \
--cc=carlos.aguiar@indt.org.br \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox