From: Tony Lindgren <tony@atomide.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-omap@vger.kernel.org,
Eduardo Valentin <eduardo.valentin@indt.org.br>
Subject: Re: [PATCH] OMAP: MMU_FWK: Changed Kconfig entry from tristate to bool.
Date: Fri, 28 Mar 2008 12:41:28 +0200 [thread overview]
Message-ID: <20080328104128.GY24896@atomide.com> (raw)
In-Reply-To: <1206542887-12321-1-git-send-email-edubezval@gmail.com>
* Eduardo Valentin <edubezval@gmail.com> [080326 16:49]:
> From: Eduardo Valentin <eduardo.valentin@indt.org.br>
>
> As this code uses unexported symbols, it must be always
> built-in. For this reason, a better type of its Kconfig entry
> is bool.
>
> Fixed also defconfig which sets this entry as module.
>
> Compile test only.
Pushing today.
Tony
> Signed-off-by: Eduardo Valentin <eduardo.valentin@indt.org.br>
> ---
> arch/arm/configs/ams_delta_defconfig | 2 +-
> arch/arm/plat-omap/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/configs/ams_delta_defconfig b/arch/arm/configs/ams_delta_defconfig
> index a6b77ab..2c4aa11 100644
> --- a/arch/arm/configs/ams_delta_defconfig
> +++ b/arch/arm/configs/ams_delta_defconfig
> @@ -164,7 +164,7 @@ CONFIG_OMAP_MUX=y
> # CONFIG_OMAP_MUX_DEBUG is not set
> CONFIG_OMAP_MUX_WARNINGS=y
> CONFIG_OMAP_MCBSP=y
> -CONFIG_OMAP_MMU_FWK=m
> +CONFIG_OMAP_MMU_FWK=y
> CONFIG_OMAP_MBOX_FWK=m
> CONFIG_OMAP_MPU_TIMER=y
> # CONFIG_OMAP_32K_TIMER is not set
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index 50291ed..536f8aa 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -122,7 +122,7 @@ config OMAP_MCBSP
> Buffered Serial Port.
>
> config OMAP_MMU_FWK
> - tristate "MMU framework support"
> + bool "MMU framework support"
> depends on ARCH_OMAP
> default n
> help
> --
> 1.5.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-28 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 14:48 [PATCH] OMAP: MMU_FWK: Changed Kconfig entry from tristate to bool Eduardo Valentin
2008-03-28 10:41 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328104128.GY24896@atomide.com \
--to=tony@atomide.com \
--cc=eduardo.valentin@indt.org.br \
--cc=edubezval@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox