From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Francisco Alecrim <francisco.alecrim@indt.org.br>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] i2c: Update twl4030's includes
Date: Mon, 31 Mar 2008 13:44:38 +0300 [thread overview]
Message-ID: <20080331104438.GI26502@atomide.com> (raw)
In-Reply-To: <20080331085436.GA4467@kedavra.cpe.vivax.com.br>
* Felipe Balbi <me@felipebalbi.com> [080331 11:53]:
> On Sat, Mar 29, 2008 at 09:00:19PM +0200, Francisco Alecrim wrote:
> > Update twl4030's includes. Headers now available under include/linux/i2c.
> >
> > arch/arm/mach-omap2/board-2430sdp.c:41:34: error: asm/arch/twl4030-rtc.h: No such file or directory
> > drivers/video/omap/lcd_2430sdp.c:30:30: error: asm/arch/twl4030.h: No such file or directory
> >
> > Signed-off-by: Francisco Alecrim <francisco.alecrim@indt.org.br>
>
> Good catch, thanks.
> Stupid grep not working :-p
Pushing today.
Tony
>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
>
> > ---
> > arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> > drivers/video/omap/lcd_2430sdp.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> > index c2d3c4d..5228d29 100644
> > --- a/arch/arm/mach-omap2/board-2430sdp.c
> > +++ b/arch/arm/mach-omap2/board-2430sdp.c
> > @@ -24,6 +24,7 @@
> > #include <linux/clk.h>
> > #include <linux/spi/spi.h>
> > #include <linux/spi/ads7846.h>
> > +#include <linux/i2c/twl4030-rtc.h>
> >
> > #include <asm/hardware.h>
> > #include <asm/mach-types.h>
> > @@ -38,7 +39,6 @@
> > #include <asm/arch/keypad.h>
> > #include <asm/arch/gpmc.h>
> > #include <asm/arch/mcspi.h>
> > -#include <asm/arch/twl4030-rtc.h>
> >
> > #include <asm/io.h>
> >
> > diff --git a/drivers/video/omap/lcd_2430sdp.c b/drivers/video/omap/lcd_2430sdp.c
> > index 2464e85..8ba15dc 100644
> > --- a/drivers/video/omap/lcd_2430sdp.c
> > +++ b/drivers/video/omap/lcd_2430sdp.c
> > @@ -23,11 +23,11 @@
> >
> > #include <linux/module.h>
> > #include <linux/platform_device.h>
> > +#include <linux/i2c/twl4030.h>
> >
> > #include <asm/arch/gpio.h>
> > #include <asm/arch/mux.h>
> > #include <asm/arch/omapfb.h>
> > -#include <asm/arch/twl4030.h>
> > #include <asm/mach-types.h>
> >
> > #define SDP2430_LCD_PANEL_BACKLIGHT_GPIO 91
> > --
> > 1.5.4.23.gef5b9
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Best Regards,
>
> Felipe Balbi
> me@felipebalbi.com
> http://blog.felipebalbi.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-03-31 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 19:00 [PATCH] i2c: Update twl4030's includes Francisco Alecrim
2008-03-31 8:54 ` Felipe Balbi
2008-03-31 10:44 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331104438.GI26502@atomide.com \
--to=tony@atomide.com \
--cc=francisco.alecrim@indt.org.br \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox