Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

[Daniel Stone <daniel.stone@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On Wed, Apr 09, 2008 at 09:05:58PM +0300, ext Felipe Balbi wrote:
> On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote:
> > Question not really related to this patchset, but in the TSC2005
> > driver some averaging and limit checks are done to the ADC values.
> > Shouldn't that be done in userspace instead?  (The ADS784x and TSC2301
> > drivers do the same evidently.)
> 
> Now that's not really up to me, but if we move it now it probably won't
> provide the feature n810 needs. I mean, n810 is designed on top of the
> features provided by driver, the application probably expects the driver
> to do the averaging and limit checks so at least for tsc2005 I think
> it's not a good idea to change due to application requirements.

It's specific to the device (and device _build_): the actual
touchscreen, and how it's working in the device, so a combination of LCD
driver and board files sounds best to me.

Cheers,
Daniel

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]