From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 5/17] ARM: OMAP2: Change 24xx to use new register access Date: Wed, 9 Apr 2008 22:22:03 +0100 Message-ID: <20080409212203.GA31636@flint.arm.linux.org.uk> References: <1205848935-12078-1-git-send-email-tony@atomide.com> <1205848935-12078-2-git-send-email-tony@atomide.com> <1205848935-12078-3-git-send-email-tony@atomide.com> <1205848935-12078-4-git-send-email-tony@atomide.com> <1205848935-12078-5-git-send-email-tony@atomide.com> <1205848935-12078-6-git-send-email-tony@atomide.com> <20080407164856.GG5306@flint.arm.linux.org.uk> <20080409205713.GM31071@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46048 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754789AbYDIVWN (ORCPT ); Wed, 9 Apr 2008 17:22:13 -0400 Content-Disposition: inline In-Reply-To: <20080409205713.GM31071@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org On Wed, Apr 09, 2008 at 08:57:13PM +0000, Tony Lindgren wrote: > Here's how it now looks: Not quite. The point I was trying to make is: > @@ -302,15 +288,17 @@ > int eth_cs; > unsigned long cs_mem_base; > unsigned int muxed, rate; > - struct clk *l3ck; > + struct clk *gpmc_fck; > > eth_cs = H4_SMC91X_CS; > > - l3ck = clk_get(NULL, "core_l3_ck"); > - if (IS_ERR(l3ck)) > - rate = 100000000; > - else > - rate = clk_get_rate(l3ck); > + gpmc_fck = clk_get(NULL, "gpmc_fck"); /* Always on ENABLE_ON_INIT */ > + if (IS_ERR(gpmc_fck)) { > + WARN_ON(1); > + return; > + } > + that there should be a call to clk_enable() here - if even if it's apparantly "always on". (If it's always enabled then the call won't do any harm anyway - it just serves to ensure that the API conditions are followed.) > + rate = clk_get_rate(gpmc_fck); > > if (is_gpmc_muxed()) > muxed = 0x200; > > Will repost the whole series. > > Tony