[RFC PATCH] musb: fix "musb_hdrc: invalid ep 8" messages

[RFC PATCH] musb: fix "musb_hdrc: invalid ep 8" messages

[Paul Walmsley]

This patch fixes the "musb_hdrc: invalid ep 8" messages that show up on
boot with current linux-omap git head on OMAP3430SDP ES2.1.  I guess that
the musb driver comes up in FIFO mode 4 with 16 endpoints defined, but the 
driver is limited to 8 endpoints by macros in hdrc_cnf.h.

Anyway, I don't know much about MUSB.  David or Felipe, maybe you could 
take a quick look at this patch?


Signed-off-by: Paul Walmsley <paul@pwsan.com>

---
 include/asm-arm/arch-omap/hdrc_cnf.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h
===================================================================
--- linux-omap.orig/include/asm-arm/arch-omap/hdrc_cnf.h	2007-08-27 02:19:07.000000000 -0600
+++ linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h	2008-04-01 11:10:34.000000000 -0600
@@ -14,11 +14,11 @@
 
 /* ** Number of Tx endpoints ** */
 /* Legal values are 1 - 16 (this value includes EP0) */
-#define MUSB_C_NUM_EPT 8
+#define MUSB_C_NUM_EPT 16
 
 /* ** Number of Rx endpoints ** */
 /* Legal values are 1 - 16 (this value includes EP0) */
-#define MUSB_C_NUM_EPR 8
+#define MUSB_C_NUM_EPR 16
 
 /* ** Endpoint 1 to 15 direction types ** */
 /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are used */
@@ -163,7 +163,7 @@
  * Legal values are 2 - 16
  * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR
  */
-#define MUSB_C_NUM_EPS 8
+#define MUSB_C_NUM_EPS 16
 
 /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits */
 #define MUSB_C_EPMAX_BITS 12

Re: [RFC PATCH] musb: fix "musb_hdrc: invalid ep 8" messages

[Felipe Balbi]

On Thu, 10 Apr 2008 11:45:32 -0600 (MDT), Paul Walmsley <paul@pwsan.com>
wrote:
> 
> This patch fixes the "musb_hdrc: invalid ep 8" messages that show up on
> boot with current linux-omap git head on OMAP3430SDP ES2.1.  I guess that
> the musb driver comes up in FIFO mode 4 with 16 endpoints defined, but
the
> driver is limited to 8 endpoints by macros in hdrc_cnf.h.
> 
> Anyway, I don't know much about MUSB.  David or Felipe, maybe you could
> take a quick look at this patch?

I had this same patch queued for sending but i was waiting until i finished
a whole series for musb driver. :-)

It's acked, if dave doesn't have any comments i think it should be applied.

> 
> 
> Signed-off-by: Paul Walmsley <paul@pwsan.com>

Acked-by Felipe Balbi <felipe.balbi@nokia.com>

> 
> ---
>  include/asm-arm/arch-omap/hdrc_cnf.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h
> ===================================================================
> --- linux-omap.orig/include/asm-arm/arch-omap/hdrc_cnf.h	2007-08-27
> 02:19:07.000000000 -0600
> +++ linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h	2008-04-01
> 11:10:34.000000000 -0600
> @@ -14,11 +14,11 @@
> 
>  /* ** Number of Tx endpoints ** */
>  /* Legal values are 1 - 16 (this value includes EP0) */
> -#define MUSB_C_NUM_EPT 8
> +#define MUSB_C_NUM_EPT 16
> 
>  /* ** Number of Rx endpoints ** */
>  /* Legal values are 1 - 16 (this value includes EP0) */
> -#define MUSB_C_NUM_EPR 8
> +#define MUSB_C_NUM_EPR 16
> 
>  /* ** Endpoint 1 to 15 direction types ** */
>  /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are
used
> */
> @@ -163,7 +163,7 @@
>   * Legal values are 2 - 16
>   * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR
>   */
> -#define MUSB_C_NUM_EPS 8
> +#define MUSB_C_NUM_EPS 16
> 
>  /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits
> */
>  #define MUSB_C_EPMAX_BITS 12
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Best Regards,

Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com

Re: [RFC PATCH] musb: fix "musb_hdrc: invalid ep 8" messages

[David Brownell]

On Thursday 10 April 2008, Felipe Balbi wrote:
> > driver is limited to 8 endpoints by macros in hdrc_cnf.h.
> > 
> > Anyway, I don't know much about MUSB.  David or Felipe, maybe you could
> > take a quick look at this patch?
> 
> I had this same patch queued for sending but i was waiting until i finished
> a whole series for musb driver. :-)
> 
> It's acked, if dave doesn't have any comments i think it should be applied.

I don't know who added that hdrc_cnf.h ... it seems to not
match the 3430 hardware though.  What *does* it match?
It claims to match DaVinci, but that's obviously wrong.

It would be good to confirm that the 2430, 34xx, and 35xx
all have the same silicon parameters for musb_hdrc, and
that they match that hdrc_cnf.h header ... that's something
which I suspect TI is in the best position to confirm. The
file is after all generated by compiling the Mentor core
for the OMAP chips.  :)

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RFC PATCH] musb: fix "musb_hdrc: invalid ep 8" messages

[Gadiyar, Anand]

> > > driver is limited to 8 endpoints by macros in hdrc_cnf.h.
> > > 
> > > Anyway, I don't know much about MUSB.  David or Felipe, maybe you could
> > > take a quick look at this patch?
> > 
> > I had this same patch queued for sending but i was waiting until i finished
> > a whole series for musb driver. :-)
> > 
> > It's acked, if dave doesn't have any comments i think it should be applied.
> 
> I don't know who added that hdrc_cnf.h ... it seems to not
> match the 3430 hardware though.  What *does* it match?
> It claims to match DaVinci, but that's obviously wrong.
> 
> It would be good to confirm that the 2430, 34xx, and 35xx
> all have the same silicon parameters for musb_hdrc, and
> that they match that hdrc_cnf.h header ... that's something
> which I suspect TI is in the best position to confirm. The
> file is after all generated by compiling the Mentor core
> for the OMAP chips.  :)

We have an updated version of this file. I will be sending it in later today.
It includes Paul's changes plus an additional set of corrections.

We somehow overlooked this file earlier. Thanks for catching this one Paul.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html