Re: [PATCH 01/23] I2C: TWL4030: checkpatch.pl fixes for twl4030-core.c

[David Brownell <david-b@pacbell.net>]

On Friday 11 April 2008, Gadiyar, Anand wrote:
> >  static int __init twl4030_init(void)
> >  {
> > -     int res;
> > -
> > -     if ((res = i2c_add_driver(&twl4030_driver))) {
> > -             printk(KERN_ERR "TWL4030: Driver registration failed\n");
> > -             return res;
> > -     }
> > -
> > -     pr_info(KERN_INFO "TWL4030: Driver registration complete.\n");
> > -
> > -     return 0;
> > +     return i2c_add_driver(&twl4030_driver);
> >  }
> 
> You're losing the failure print here. Not sure if it matters, but
> I'm pointing it out anyway. 

Doesn't matter; the standard policy is to have module init
just add the drivers and let the subsystems handle any
(unlikely) warning messages.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html