From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] I2C: TWL4030: Fix wrong variable warning
Date: Fri, 11 Apr 2008 12:05:55 -0700 [thread overview]
Message-ID: <20080411190555.GF7717@atomide.com> (raw)
In-Reply-To: <1207914696-24035-1-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080411 04:53]:
> twl4030_i2c_write_u8 expects a u8 variable.
> Change ctrl to be u8 in power_companion_init().
Pushing.
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/i2c/chips/twl4030-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
> index eedbebd..934433e 100644
> --- a/drivers/i2c/chips/twl4030-core.c
> +++ b/drivers/i2c/chips/twl4030-core.c
> @@ -679,7 +679,8 @@ static int unprotect_pm_master(void)
> static int power_companion_init(void)
> {
> struct clk *osc;
> - u32 rate, ctrl = HFCLK_FREQ_26_MHZ;
> + u32 rate;
> + u8 ctrl = HFCLK_FREQ_26_MHZ;
> int e = 0;
>
> if (cpu_is_omap2430())
> --
> 1.5.5.29.g7134
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-11 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 11:51 [PATCH] I2C: TWL4030: Fix wrong variable warning Felipe Balbi
2008-04-11 19:05 ` Tony Lindgren [this message]
2008-04-14 18:13 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411190555.GF7717@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox