* [PATCH] I2C: TWL4030: Fix wrong variable warning
@ 2008-04-11 11:51 Felipe Balbi
2008-04-11 19:05 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2008-04-11 11:51 UTC (permalink / raw)
To: linux-omap; +Cc: Felipe Balbi
twl4030_i2c_write_u8 expects a u8 variable.
Change ctrl to be u8 in power_companion_init().
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
drivers/i2c/chips/twl4030-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
index eedbebd..934433e 100644
--- a/drivers/i2c/chips/twl4030-core.c
+++ b/drivers/i2c/chips/twl4030-core.c
@@ -679,7 +679,8 @@ static int unprotect_pm_master(void)
static int power_companion_init(void)
{
struct clk *osc;
- u32 rate, ctrl = HFCLK_FREQ_26_MHZ;
+ u32 rate;
+ u8 ctrl = HFCLK_FREQ_26_MHZ;
int e = 0;
if (cpu_is_omap2430())
--
1.5.5.29.g7134
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] I2C: TWL4030: Fix wrong variable warning
2008-04-11 11:51 [PATCH] I2C: TWL4030: Fix wrong variable warning Felipe Balbi
@ 2008-04-11 19:05 ` Tony Lindgren
2008-04-14 18:13 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2008-04-11 19:05 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap
* Felipe Balbi <felipe.balbi@nokia.com> [080411 04:53]:
> twl4030_i2c_write_u8 expects a u8 variable.
> Change ctrl to be u8 in power_companion_init().
Pushing.
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/i2c/chips/twl4030-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
> index eedbebd..934433e 100644
> --- a/drivers/i2c/chips/twl4030-core.c
> +++ b/drivers/i2c/chips/twl4030-core.c
> @@ -679,7 +679,8 @@ static int unprotect_pm_master(void)
> static int power_companion_init(void)
> {
> struct clk *osc;
> - u32 rate, ctrl = HFCLK_FREQ_26_MHZ;
> + u32 rate;
> + u8 ctrl = HFCLK_FREQ_26_MHZ;
> int e = 0;
>
> if (cpu_is_omap2430())
> --
> 1.5.5.29.g7134
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] I2C: TWL4030: Fix wrong variable warning
2008-04-11 19:05 ` Tony Lindgren
@ 2008-04-14 18:13 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2008-04-14 18:13 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap
On Fri, Apr 11, 2008 at 12:05:55PM -0700, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [080411 04:53]:
> > twl4030_i2c_write_u8 expects a u8 variable.
> > Change ctrl to be u8 in power_companion_init().
>
> Pushing.
thanks :-)
I'll check if we still owe you any driver and try to publish it/them as
well.
--
Best Regards,
Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-14 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 11:51 [PATCH] I2C: TWL4030: Fix wrong variable warning Felipe Balbi
2008-04-11 19:05 ` Tony Lindgren
2008-04-14 18:13 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox