From: Tony Lindgren <tony@atomide.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: USB: Fix potential resource overlap due to incorrect end address
Date: Fri, 11 Apr 2008 12:32:16 -0700 [thread overview]
Message-ID: <20080411193215.GK7717@atomide.com> (raw)
In-Reply-To: <010C7BAE6783F34D9AC336EE5A01A08805C30691@dbde01.ent.ti.com>
* Gadiyar, Anand <gadiyar@ti.com> [080408 05:08]:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> The end address for the USB memory resources were incorrectly defined as
> (<start> + <size>) instead of (<start> + <size - 1>) resulting in a
> potential overlap with the start address of other resources.
Pushing today.
Tony
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Acked-by: Nishant Kamat <nskamat@ti.com>
> ---
> arch/arm/mach-omap2/board-2430sdp-usb.c | 2 +-
> arch/arm/mach-omap2/board-3430sdp-usb.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp-usb.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/mach-omap2/board-2430sdp-usb.c 2008-04-08 17:28:40.000000000 +0530
> +++ linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp-usb.c 2008-04-08 17:29:54.868278300 +0530
> @@ -23,7 +23,7 @@
> static struct resource musb_resources[] = {
> [0] = {
> .start = OMAP243X_HS_BASE,
> - .end = OMAP243X_HS_BASE + SZ_8K,
> + .end = OMAP243X_HS_BASE + SZ_8K - 1,
> .flags = IORESOURCE_MEM,
> },
> [1] = { /* general IRQ */
> Index: linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp-usb.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/mach-omap2/board-3430sdp-usb.c 2008-04-08 17:28:40.000000000 +0530
> +++ linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp-usb.c 2008-04-08 17:30:21.938407487 +0530
> @@ -29,7 +29,7 @@
> static struct resource musb_resources[] = {
> [0] = {
> .start = OMAP34XX_HSUSB_OTG_BASE,
> - .end = OMAP34XX_HSUSB_OTG_BASE + SZ_8K,
> + .end = OMAP34XX_HSUSB_OTG_BASE + SZ_8K - 1,
> .flags = IORESOURCE_MEM,
> },
> [1] = { /* general IRQ */
> @@ -100,7 +100,7 @@ static struct platform_device musb_devic
> static struct resource ehci_resources[] = {
> [0] = {
> .start = OMAP34XX_HSUSB_HOST_BASE + 0x800,
> - .end = OMAP34XX_HSUSB_HOST_BASE + 0x800 + SZ_1K,
> + .end = OMAP34XX_HSUSB_HOST_BASE + 0x800 + SZ_1K - 1,
> .flags = IORESOURCE_MEM,
> },
> [1] = { /* general IRQ */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-04-11 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 12:07 [PATCH] ARM: OMAP: USB: Fix potential resource overlap due to incorrect end address Gadiyar, Anand
2008-04-11 19:32 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411193215.GK7717@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox