* [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
@ 2008-04-14 12:06 Syed Mohammed, Khasim
2008-04-14 18:04 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Syed Mohammed, Khasim @ 2008-04-14 12:06 UTC (permalink / raw)
To: linux-omap
Updated Kconfig and Makefile for OMAP3 EVM support
Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
---
arch/arm/mach-omap2/Kconfig | 10 +++++++---
arch/arm/mach-omap2/Makefile | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
Index: my_branch/arch/arm/mach-omap2/Kconfig
===================================================================
--- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14 16:07:11.000000000 +0530
+++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14 16:07:41.000000000 +0530
@@ -98,10 +98,14 @@
bool "OMAP 2430 SDP board"
depends on ARCH_OMAP2 && ARCH_OMAP2430
+config MACH_OMAP_2430OSK
+ bool "OMAP 2430 OSK board"
+ depends on ARCH_OMAP2 && ARCH_OMAP24XX
+
config MACH_OMAP_3430SDP
bool "OMAP 3430 SDP board"
depends on ARCH_OMAP3 && ARCH_OMAP34XX
-config MACH_OMAP_2430OSK
- bool "OMAP 2430 OSK board"
- depends on ARCH_OMAP2 && ARCH_OMAP24XX
+config MACH_OMAP3EVM
+ bool "OMAP 3530 EVM board"
+ depends on ARCH_OMAP3 && ARCH_OMAP34XX
Index: my_branch/arch/arm/mach-omap2/Makefile
===================================================================
--- my_branch.orig/arch/arm/mach-omap2/Makefile 2008-04-14 16:07:11.000000000 +0530
+++ my_branch/arch/arm/mach-omap2/Makefile 2008-04-14 16:07:41.000000000 +0530
@@ -34,6 +34,7 @@
board-sdp-hsmmc.o \
board-3430sdp-usb.o \
board-3430sdp-flash.o
+obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3-evm.o
obj-$(CONFIG_MACH_OMAP_APOLLON) += board-apollon.o \
board-apollon-mmc.o \
board-apollon-keys.o
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-14 12:06 [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support Syed Mohammed, Khasim
@ 2008-04-14 18:04 ` Felipe Balbi
2008-04-15 7:13 ` Syed Mohammed, Khasim
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2008-04-14 18:04 UTC (permalink / raw)
To: Syed Mohammed, Khasim; +Cc: linux-omap
On Mon, Apr 14, 2008 at 05:36:50PM +0530, Syed Mohammed, Khasim wrote:
>
> Updated Kconfig and Makefile for OMAP3 EVM support
>
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> ---
> arch/arm/mach-omap2/Kconfig | 10 +++++++---
> arch/arm/mach-omap2/Makefile | 1 +
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> Index: my_branch/arch/arm/mach-omap2/Kconfig
> ===================================================================
> --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14 16:07:11.000000000 +0530
> +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14 16:07:41.000000000 +0530
> @@ -98,10 +98,14 @@
> bool "OMAP 2430 SDP board"
> depends on ARCH_OMAP2 && ARCH_OMAP2430
>
> +config MACH_OMAP_2430OSK
> + bool "OMAP 2430 OSK board"
> + depends on ARCH_OMAP2 && ARCH_OMAP24XX
> +
> config MACH_OMAP_3430SDP
> bool "OMAP 3430 SDP board"
> depends on ARCH_OMAP3 && ARCH_OMAP34XX
>
> -config MACH_OMAP_2430OSK
> - bool "OMAP 2430 OSK board"
> - depends on ARCH_OMAP2 && ARCH_OMAP24XX
> +config MACH_OMAP3EVM
> + bool "OMAP 3530 EVM board"
> + depends on ARCH_OMAP3 && ARCH_OMAP34XX
Do you really need to move 2430OSK here?
It looks like unnecessary change.
please revert.
>
> Index: my_branch/arch/arm/mach-omap2/Makefile
> ===================================================================
> --- my_branch.orig/arch/arm/mach-omap2/Makefile 2008-04-14 16:07:11.000000000 +0530
> +++ my_branch/arch/arm/mach-omap2/Makefile 2008-04-14 16:07:41.000000000 +0530
> @@ -34,6 +34,7 @@
> board-sdp-hsmmc.o \
> board-3430sdp-usb.o \
> board-3430sdp-flash.o
> +obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3-evm.o
> obj-$(CONFIG_MACH_OMAP_APOLLON) += board-apollon.o \
> board-apollon-mmc.o \
> board-apollon-keys.o
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards,
Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-14 18:04 ` Felipe Balbi
@ 2008-04-15 7:13 ` Syed Mohammed, Khasim
2008-04-15 8:20 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Syed Mohammed, Khasim @ 2008-04-15 7:13 UTC (permalink / raw)
To: me; +Cc: linux-omap
> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com]
> Sent: Monday, April 14, 2008 11:35 PM
> To: Syed Mohammed, Khasim
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM
> support
>
> On Mon, Apr 14, 2008 at 05:36:50PM +0530, Syed Mohammed, Khasim wrote:
> >
> > Updated Kconfig and Makefile for OMAP3 EVM support
> >
> > Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> > ---
> > arch/arm/mach-omap2/Kconfig | 10 +++++++---
> > arch/arm/mach-omap2/Makefile | 1 +
> > 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > Index: my_branch/arch/arm/mach-omap2/Kconfig
> > ===================================================================
> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14
> 16:07:11.000000000 +0530
> > +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14
> 16:07:41.000000000 +0530
> > @@ -98,10 +98,14 @@
> > bool "OMAP 2430 SDP board"
> > depends on ARCH_OMAP2 && ARCH_OMAP2430
> >
> > +config MACH_OMAP_2430OSK
> > + bool "OMAP 2430 OSK board"
> > + depends on ARCH_OMAP2 && ARCH_OMAP24XX
> > +
> > config MACH_OMAP_3430SDP
> > bool "OMAP 3430 SDP board"
> > depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >
> > -config MACH_OMAP_2430OSK
> > - bool "OMAP 2430 OSK board"
> > - depends on ARCH_OMAP2 && ARCH_OMAP24XX
> > +config MACH_OMAP3EVM
> > + bool "OMAP 3530 EVM board"
> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
>
> Do you really need to move 2430OSK here?
> It looks like unnecessary change.
>
> please revert.
>
This change is good as it lists all omap2 followed by omap3 boards. Otherwise it mixes OMAP2 boards with OMAP3 boards.
Regards,
Khasim
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-15 7:13 ` Syed Mohammed, Khasim
@ 2008-04-15 8:20 ` Felipe Balbi
2008-04-15 9:20 ` Syed Mohammed, Khasim
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2008-04-15 8:20 UTC (permalink / raw)
To: Syed Mohammed, Khasim; +Cc: linux-omap
On Tue, 15 Apr 2008 12:43:10 +0530, "Syed Mohammed, Khasim" <khasim@ti.com>
wrote:
>
>
>> -----Original Message-----
>> From: Felipe Balbi [mailto:me@felipebalbi.com]
>> Sent: Monday, April 14, 2008 11:35 PM
>> To: Syed Mohammed, Khasim
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM
>> support
>>
>> On Mon, Apr 14, 2008 at 05:36:50PM +0530, Syed Mohammed, Khasim wrote:
>> >
>> > Updated Kconfig and Makefile for OMAP3 EVM support
>> >
>> > Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>> > ---
>> > arch/arm/mach-omap2/Kconfig | 10 +++++++---
>> > arch/arm/mach-omap2/Makefile | 1 +
>> > 2 files changed, 8 insertions(+), 3 deletions(-)
>> >
>> > Index: my_branch/arch/arm/mach-omap2/Kconfig
>> > ===================================================================
>> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14
>> 16:07:11.000000000 +0530
>> > +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14
>> 16:07:41.000000000 +0530
>> > @@ -98,10 +98,14 @@
>> > bool "OMAP 2430 SDP board"
>> > depends on ARCH_OMAP2 && ARCH_OMAP2430
>> >
>> > +config MACH_OMAP_2430OSK
>> > + bool "OMAP 2430 OSK board"
>> > + depends on ARCH_OMAP2 && ARCH_OMAP24XX
>> > +
>> > config MACH_OMAP_3430SDP
>> > bool "OMAP 3430 SDP board"
>> > depends on ARCH_OMAP3 && ARCH_OMAP34XX
>> >
>> > -config MACH_OMAP_2430OSK
>> > - bool "OMAP 2430 OSK board"
>> > - depends on ARCH_OMAP2 && ARCH_OMAP24XX
>> > +config MACH_OMAP3EVM
>> > + bool "OMAP 3530 EVM board"
>> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
>>
>> Do you really need to move 2430OSK here?
>> It looks like unnecessary change.
>>
>> please revert.
>>
> This change is good as it lists all omap2 followed by omap3 boards.
> Otherwise it mixes OMAP2 boards with OMAP3 boards.
so put it in a separate patch. It has nothing to do with
"Adding support for OMAP3 EVM"
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-15 8:20 ` Felipe Balbi
@ 2008-04-15 9:20 ` Syed Mohammed, Khasim
2008-04-15 9:33 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Syed Mohammed, Khasim @ 2008-04-15 9:20 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap
>
> >> > Index: my_branch/arch/arm/mach-omap2/Kconfig
> >> > ===================================================================
> >> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14
> >> 16:07:11.000000000 +0530
> >> > +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14
> >> 16:07:41.000000000 +0530
> >> > @@ -98,10 +98,14 @@
> >> > bool "OMAP 2430 SDP board"
> >> > depends on ARCH_OMAP2 && ARCH_OMAP2430
> >> >
> >> > +config MACH_OMAP_2430OSK
> >> > + bool "OMAP 2430 OSK board"
> >> > + depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> > +
> >> > config MACH_OMAP_3430SDP
> >> > bool "OMAP 3430 SDP board"
> >> > depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >> >
> >> > -config MACH_OMAP_2430OSK
> >> > - bool "OMAP 2430 OSK board"
> >> > - depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> > +config MACH_OMAP3EVM
> >> > + bool "OMAP 3530 EVM board"
> >> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >>
> >> Do you really need to move 2430OSK here?
> >> It looks like unnecessary change.
> >>
> >> please revert.
> >>
> > This change is good as it lists all omap2 followed by omap3 boards.
> > Otherwise it mixes OMAP2 boards with OMAP3 boards.
>
> so put it in a separate patch. It has nothing to do with
> "Adding support for OMAP3 EVM"
Why? ???
These lines add OMAP3 EVM
+config MACH_OMAP3EVM
+ bool "OMAP 3530 EVM board"
+ depends on ARCH_OMAP3 && ARCH_OMAP34XX
The other lines are re-arranging OMAP2 and OMAP3 boards.
We can make two separate patches but this fix seems to be simple.
Regards,
Khasim
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-15 9:20 ` Syed Mohammed, Khasim
@ 2008-04-15 9:33 ` Felipe Balbi
2008-04-16 20:49 ` Tony Lindgren
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2008-04-15 9:33 UTC (permalink / raw)
To: Syed Mohammed, Khasim; +Cc: linux-omap
On Tue, 15 Apr 2008 14:50:20 +0530, "Syed Mohammed, Khasim" <khasim@ti.com>
wrote:
>
>>
>> >> > Index: my_branch/arch/arm/mach-omap2/Kconfig
>> >> >
> ===================================================================
>> >> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14
>> >> 16:07:11.000000000 +0530
>> >> > +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14
>> >> 16:07:41.000000000 +0530
>> >> > @@ -98,10 +98,14 @@
>> >> > bool "OMAP 2430 SDP board"
>> >> > depends on ARCH_OMAP2 && ARCH_OMAP2430
>> >> >
>> >> > +config MACH_OMAP_2430OSK
>> >> > + bool "OMAP 2430 OSK board"
>> >> > + depends on ARCH_OMAP2 && ARCH_OMAP24XX
>> >> > +
>> >> > config MACH_OMAP_3430SDP
>> >> > bool "OMAP 3430 SDP board"
>> >> > depends on ARCH_OMAP3 && ARCH_OMAP34XX
>> >> >
>> >> > -config MACH_OMAP_2430OSK
>> >> > - bool "OMAP 2430 OSK board"
>> >> > - depends on ARCH_OMAP2 && ARCH_OMAP24XX
>> >> > +config MACH_OMAP3EVM
>> >> > + bool "OMAP 3530 EVM board"
>> >> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
>> >>
>> >> Do you really need to move 2430OSK here?
>> >> It looks like unnecessary change.
>> >>
>> >> please revert.
>> >>
>> > This change is good as it lists all omap2 followed by omap3 boards.
>> > Otherwise it mixes OMAP2 boards with OMAP3 boards.
>>
>> so put it in a separate patch. It has nothing to do with
>> "Adding support for OMAP3 EVM"
>
> Why? ???
>
> These lines add OMAP3 EVM
>
> +config MACH_OMAP3EVM
> + bool "OMAP 3530 EVM board"
> + depends on ARCH_OMAP3 && ARCH_OMAP34XX
>
> The other lines are re-arranging OMAP2 and OMAP3 boards.
Yes, re-arranging omap2/3 is another "task". Has nothing to do with
"adding omap3 evm". I'd rather see these two changes split in two
separate patches but Tony might be the one with the final word anyway. :-p
If he's ok with this patch...
>
> We can make two separate patches but this fix seems to be simple.
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support
2008-04-15 9:33 ` Felipe Balbi
@ 2008-04-16 20:49 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2008-04-16 20:49 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Syed Mohammed, Khasim, linux-omap
Hi,
* Felipe Balbi <me@felipebalbi.com> [080415 02:34]:
>
>
> On Tue, 15 Apr 2008 14:50:20 +0530, "Syed Mohammed, Khasim" <khasim@ti.com>
> wrote:
> >
> >>
> >> >> > Index: my_branch/arch/arm/mach-omap2/Kconfig
> >> >> >
> > ===================================================================
> >> >> > --- my_branch.orig/arch/arm/mach-omap2/Kconfig 2008-04-14
> >> >> 16:07:11.000000000 +0530
> >> >> > +++ my_branch/arch/arm/mach-omap2/Kconfig 2008-04-14
> >> >> 16:07:41.000000000 +0530
> >> >> > @@ -98,10 +98,14 @@
> >> >> > bool "OMAP 2430 SDP board"
> >> >> > depends on ARCH_OMAP2 && ARCH_OMAP2430
> >> >> >
> >> >> > +config MACH_OMAP_2430OSK
> >> >> > + bool "OMAP 2430 OSK board"
> >> >> > + depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> >> > +
> >> >> > config MACH_OMAP_3430SDP
> >> >> > bool "OMAP 3430 SDP board"
> >> >> > depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >> >> >
> >> >> > -config MACH_OMAP_2430OSK
> >> >> > - bool "OMAP 2430 OSK board"
> >> >> > - depends on ARCH_OMAP2 && ARCH_OMAP24XX
> >> >> > +config MACH_OMAP3EVM
> >> >> > + bool "OMAP 3530 EVM board"
> >> >> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >> >>
> >> >> Do you really need to move 2430OSK here?
> >> >> It looks like unnecessary change.
> >> >>
> >> >> please revert.
> >> >>
> >> > This change is good as it lists all omap2 followed by omap3 boards.
> >> > Otherwise it mixes OMAP2 boards with OMAP3 boards.
> >>
> >> so put it in a separate patch. It has nothing to do with
> >> "Adding support for OMAP3 EVM"
> >
> > Why? ???
> >
> > These lines add OMAP3 EVM
> >
> > +config MACH_OMAP3EVM
> > + bool "OMAP 3530 EVM board"
> > + depends on ARCH_OMAP3 && ARCH_OMAP34XX
> >
> > The other lines are re-arranging OMAP2 and OMAP3 boards.
>
> Yes, re-arranging omap2/3 is another "task". Has nothing to do with
> "adding omap3 evm". I'd rather see these two changes split in two
> separate patches but Tony might be the one with the final word anyway. :-p
> If he's ok with this patch...
>
> >
> > We can make two separate patches but this fix seems to be simple.
Looks like they're separate now, good. In general patches should be
separate and independent of each other.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-04-16 20:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 12:06 [PATCH 1/4] Updating Kconfig and Makefile for OMAP3 EVM support Syed Mohammed, Khasim
2008-04-14 18:04 ` Felipe Balbi
2008-04-15 7:13 ` Syed Mohammed, Khasim
2008-04-15 8:20 ` Felipe Balbi
2008-04-15 9:20 ` Syed Mohammed, Khasim
2008-04-15 9:33 ` Felipe Balbi
2008-04-16 20:49 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox