From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/5] Powerdomains: Add OMAP3 powerdomains
Date: Wed, 16 Apr 2008 14:42:31 -0700 [thread overview]
Message-ID: <20080416214228.GO17055@atomide.com> (raw)
In-Reply-To: <20080410153344.268066631@pwsan.com>
* Paul Walmsley <paul@pwsan.com> [080410 10:16]:
> Add OMAP3 powerdomains
This one seems to be missing S-o-b.
Tony
> ---
> arch/arm/mach-omap2/powerdomains.h | 20 ++
> arch/arm/mach-omap2/powerdomains34xx.h | 296 +++++++++++++++++++++++++++++++++
> arch/arm/mach-omap2/prcm-common.h | 3
> arch/arm/mach-omap2/prm-regbits-34xx.h | 11 -
> 4 files changed, 323 insertions(+), 7 deletions(-)
>
> Index: linux-omap/arch/arm/mach-omap2/powerdomains.h
> ===================================================================
> --- linux-omap.orig/arch/arm/mach-omap2/powerdomains.h 2008-04-10 08:41:54.000000000 -0600
> +++ linux-omap/arch/arm/mach-omap2/powerdomains.h 2008-04-10 08:41:54.000000000 -0600
> @@ -95,9 +95,12 @@
> { NULL },
> };
>
> -/* Include 24XX-specific powerdomains (which may reference the above wkdeps) */
> -
> +/*
> + * Include 24XX & 34XX-specific powerdomains (which may reference the
> + * above wkdeps)
> + */
> #include "powerdomains24xx.h"
> +#include "powerdomains34xx.h"
>
>
> /*
> @@ -151,6 +154,19 @@
> &mdm_pwrdm,
> #endif
>
> +#ifdef CONFIG_ARCH_OMAP34XX
> + &iva2_pwrdm,
> + &mpu_34xx_pwrdm,
> + &neon_pwrdm,
> + &core_34xx_pwrdm,
> + &cam_pwrdm,
> + &dss_pwrdm,
> + &per_pwrdm,
> + &emu_pwrdm,
> + &sgx_pwrdm,
> + &usbhost_pwrdm,
> +#endif
> +
> NULL
> };
>
> Index: linux-omap/arch/arm/mach-omap2/powerdomains34xx.h
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-omap/arch/arm/mach-omap2/powerdomains34xx.h 2008-04-10 08:41:54.000000000 -0600
> @@ -0,0 +1,296 @@
> +/*
> + * OMAP34XX powerdomain definitions
> + *
> + * Copyright (C) 2007-8 Texas Instruments, Inc.
> + * Copyright (C) 2007-8 Nokia Corporation
> + *
> + * Written by Paul Walmsley
> + * Debugging and integration fixes by Jouni Högander
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef ARCH_ARM_MACH_OMAP2_POWERDOMAINS34XX
> +#define ARCH_ARM_MACH_OMAP2_POWERDOMAINS34XX
> +
> +/*
> + * N.B. If powerdomains are added or removed from this file, update
> + * the array in mach-omap2/powerdomains.h.
> + */
> +
> +#include <asm/arch/powerdomain.h>
> +
> +#include "prcm-common.h"
> +#include "prm.h"
> +#include "prm-regbits-34xx.h"
> +#include "cm.h"
> +#include "cm-regbits-34xx.h"
> +
> +/* Forward declarations - so powerdomain dependencies can be encoded */
> +
> +#ifdef CONFIG_ARCH_OMAP34XX
> +static struct powerdomain mpu_34xx_pwrdm;
> +static struct powerdomain core_34xx_pwrdm;
> +static struct powerdomain dss_pwrdm;
> +static struct powerdomain sgx_pwrdm;
> +static struct powerdomain cam_pwrdm;
> +static struct powerdomain per_pwrdm;
> +static struct powerdomain emu_pwrdm;
> +static struct powerdomain neon_pwrdm;
> +static struct powerdomain usbhost_pwrdm;
> +
> +static struct pwrdm_dep cam_gfx_sleepdeps[];
> +#endif
> +
> +
> +/*
> + * 34XX-specific powerdomains, dependencies
> + */
> +
> +#ifdef CONFIG_ARCH_OMAP34XX
> +
> +/*
> + * 3430: PM_WKDEP_{PER,USBHOST}: CORE, IVA2, MPU, WKUP
> + * (USBHOST is ES2 only)
> + */
> +static struct pwrdm_dep per_usbhost_wkdeps[] = {
> + { .pwrdm = &core_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &iva2_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &wkup_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +/*
> + * 3430 PM_WKDEP_MPU: CORE, IVA2, DSS, PER
> + */
> +static struct pwrdm_dep mpu_34xx_wkdeps[] = {
> + { .pwrdm = &core_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &iva2_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &dss_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &per_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +/*
> + * 3430 PM_WKDEP_IVA2: CORE, MPU, WKUP, DSS, PER
> + */
> +static struct pwrdm_dep iva2_wkdeps[] = {
> + { .pwrdm = &core_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &wkup_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &dss_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &per_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +
> +/* 3430 PM_WKDEP_{CAM,DSS}: IVA2, MPU, WKUP */
> +static struct pwrdm_dep cam_dss_wkdeps[] = {
> + { .pwrdm = &iva2_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { .pwrdm = &wkup_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +/* 3430: PM_WKDEP_NEON: MPU */
> +static struct pwrdm_dep neon_wkdeps[] = {
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +
> +/* Sleep dependency source arrays - 34XX only */
> +
> +/*
> + * 3430: CM_SLEEPDEP_CAM: MPU
> + * 3430ES1: CM_SLEEPDEP_GFX: MPU
> + * 3430ES2: CM_SLEEPDEP_SGX: MPU
> + */
> +static struct pwrdm_dep cam_gfx_sleepdeps[] = {
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +/*
> + * 3430: CM_SLEEPDEP_{DSS,PER}: MPU, IVA
> + * 3430ES2: CM_SLEEPDEP_USBHOST: MPU, IVA
> + */
> +static struct pwrdm_dep dss_per_usbhost_sleepdeps[] = {
> + { .pwrdm = &mpu_34xx_pwrdm, .omap_chip = CHIP_IS_OMAP3430 },
> + { NULL },
> +};
> +
> +
> +/*
> + * Powerdomains
> + */
> +
> +static struct powerdomain iva2_pwrdm = {
> + .name = "iva2_pwrdm",
> + .prcm_offs = OMAP3430_IVA2_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> + .dep_bit = OMAP3430_PM_WKDEP_MPU_EN_IVA2_SHIFT,
> + .wkdep_srcs = iva2_wkdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRSTS_OFF_RET,
> + .banks = 4,
> + .pwrsts_mem_ret = {
> + [0] = PWRSTS_OFF_RET,
> + [1] = PWRSTS_OFF_RET,
> + [2] = PWRSTS_OFF_RET,
> + [3] = PWRSTS_OFF_RET,
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON,
> + [1] = PWRDM_POWER_ON,
> + [2] = PWRSTS_OFF_ON,
> + [3] = PWRDM_POWER_ON,
> + },
> +};
> +
> +static struct powerdomain mpu_34xx_pwrdm = {
> + .name = "mpu_pwrdm",
> + .prcm_offs = MPU_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> + .dep_bit = OMAP3430_EN_MPU_SHIFT,
> + .wkdep_srcs = mpu_34xx_wkdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRSTS_OFF_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRSTS_OFF_RET,
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRSTS_OFF_ON,
> + },
> +};
> +
> +/* No wkdeps or sleepdeps for 34xx core apparently */
> +static struct powerdomain core_34xx_pwrdm = {
> + .name = "core_pwrdm",
> + .prcm_offs = CORE_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .dep_bit = OMAP3430_EN_CORE_SHIFT,
> + .banks = 2,
> + .pwrsts_mem_ret = {
> + [0] = PWRSTS_OFF_RET, /* MEM1RETSTATE */
> + [1] = PWRSTS_OFF_RET, /* MEM2RETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRSTS_OFF_RET_ON, /* MEM1ONSTATE */
> + [1] = PWRSTS_OFF_RET_ON, /* MEM2ONSTATE */
> + },
> +};
> +
> +/* Another case of bit name collisions between several registers: EN_DSS */
> +static struct powerdomain dss_pwrdm = {
> + .name = "dss_pwrdm",
> + .omap_chip = CHIP_IS_OMAP3430,
> + .prcm_offs = OMAP3430_DSS_MOD,
> + .dep_bit = OMAP3430_PM_WKDEP_MPU_EN_DSS_SHIFT,
> + .wkdep_srcs = cam_dss_wkdeps,
> + .sleepdep_srcs = dss_per_usbhost_sleepdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRDM_POWER_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRDM_POWER_RET, /* MEMRETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON, /* MEMONSTATE */
> + },
> +};
> +
> +static struct powerdomain sgx_pwrdm = {
> + .name = "sgx_pwrdm",
> + .prcm_offs = OMAP3430ES2_SGX_MOD,
> + .omap_chip = CHIP_IS_OMAP3430ES2,
> + .wkdep_srcs = gfx_sgx_wkdeps,
> + .sleepdep_srcs = cam_gfx_sleepdeps,
> + /* XXX This is accurate for 3430 SGX, but what about GFX? */
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRDM_POWER_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRDM_POWER_RET, /* MEMRETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON, /* MEMONSTATE */
> + },
> +};
> +
> +static struct powerdomain cam_pwrdm = {
> + .name = "cam_pwrdm",
> + .omap_chip = CHIP_IS_OMAP3430,
> + .prcm_offs = OMAP3430_CAM_MOD,
> + .wkdep_srcs = cam_dss_wkdeps,
> + .sleepdep_srcs = cam_gfx_sleepdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRDM_POWER_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRDM_POWER_RET, /* MEMRETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON, /* MEMONSTATE */
> + },
> +};
> +
> +static struct powerdomain per_pwrdm = {
> + .name = "per_pwrdm",
> + .prcm_offs = OMAP3430_PER_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> + .dep_bit = OMAP3430_EN_PER_SHIFT,
> + .wkdep_srcs = per_usbhost_wkdeps,
> + .sleepdep_srcs = dss_per_usbhost_sleepdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRSTS_OFF_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRDM_POWER_RET, /* MEMRETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON, /* MEMONSTATE */
> + },
> +};
> +
> +static struct powerdomain emu_pwrdm = {
> + .name = "emu_pwrdm",
> + .prcm_offs = OMAP3430_EMU_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> +};
> +
> +static struct powerdomain neon_pwrdm = {
> + .name = "neon_pwrdm",
> + .prcm_offs = OMAP3430_NEON_MOD,
> + .omap_chip = CHIP_IS_OMAP3430,
> + .wkdep_srcs = neon_wkdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRDM_POWER_RET,
> +};
> +
> +static struct powerdomain usbhost_pwrdm = {
> + .name = "usbhost_pwrdm",
> + .prcm_offs = OMAP3430ES2_USBHOST_MOD,
> + .omap_chip = CHIP_IS_OMAP3430ES2,
> + .wkdep_srcs = per_usbhost_wkdeps,
> + .sleepdep_srcs = dss_per_usbhost_sleepdeps,
> + .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts_logic_ret = PWRDM_POWER_RET,
> + .banks = 1,
> + .pwrsts_mem_ret = {
> + [0] = PWRDM_POWER_RET, /* MEMRETSTATE */
> + },
> + .pwrsts_mem_on = {
> + [0] = PWRDM_POWER_ON, /* MEMONSTATE */
> + },
> +};
> +
> +#endif /* CONFIG_ARCH_OMAP34XX */
> +
> +
> +#endif
> Index: linux-omap/arch/arm/mach-omap2/prcm-common.h
> ===================================================================
> --- linux-omap.orig/arch/arm/mach-omap2/prcm-common.h 2008-04-10 08:35:24.000000000 -0600
> +++ linux-omap/arch/arm/mach-omap2/prcm-common.h 2008-04-10 08:41:54.000000000 -0600
> @@ -311,7 +311,8 @@
> #define OMAP3430_ST_GPT2 (1 << 3)
>
> /* CM_SLEEPDEP_PER, PM_WKDEP_IVA2, PM_WKDEP_MPU, PM_WKDEP_PER shared bits */
> -#define OMAP3430_EN_CORE (1 << 0)
> +#define OMAP3430_EN_CORE_SHIFT 0
> +#define OMAP3430_EN_CORE_MASK (1 << 0)
>
> #endif
>
> Index: linux-omap/arch/arm/mach-omap2/prm-regbits-34xx.h
> ===================================================================
> --- linux-omap.orig/arch/arm/mach-omap2/prm-regbits-34xx.h 2008-04-10 08:35:24.000000000 -0600
> +++ linux-omap/arch/arm/mach-omap2/prm-regbits-34xx.h 2008-04-10 08:41:54.000000000 -0600
> @@ -68,7 +68,8 @@
> #define OMAP3430_VPINIDLE (1 << 0)
>
> /* PM_WKDEP_IVA2, PM_WKDEP_MPU shared bits */
> -#define OMAP3430_EN_PER (1 << 7)
> +#define OMAP3430_EN_PER_SHIFT 7
> +#define OMAP3430_EN_PER_MASK (1 << 7)
>
> /* PM_PWSTCTRL_IVA2, PM_PWSTCTRL_MPU, PM_PWSTCTRL_CORE shared bits */
> #define OMAP3430_MEMORYCHANGE (1 << 3)
> @@ -77,7 +78,7 @@
> #define OMAP3430_LOGICSTATEST (1 << 2)
>
> /* PM_PREPWSTST_IVA2, PM_PREPWSTST_CORE shared bits */
> -#define OMAP3430_LASTLOGICSTATEENTERED (1 << 2)
> +#define OMAP3430_LASTLOGICSTATEENTERED (1 << 2)
>
> /*
> * PM_PREPWSTST_IVA2, PM_PREPWSTST_MPU, PM_PREPWSTST_CORE,
> @@ -278,8 +279,10 @@
> #define OMAP3430_EMULATION_MPU_RST (1 << 11)
>
> /* PM_WKDEP_MPU specific bits */
> -#define OMAP3430_PM_WKDEP_MPU_EN_DSS (1 << 5)
> -#define OMAP3430_PM_WKDEP_MPU_EN_IVA2 (1 << 2)
> +#define OMAP3430_PM_WKDEP_MPU_EN_DSS_SHIFT 5
> +#define OMAP3430_PM_WKDEP_MPU_EN_DSS_MASK (1 << 5)
> +#define OMAP3430_PM_WKDEP_MPU_EN_IVA2_SHIFT 2
> +#define OMAP3430_PM_WKDEP_MPU_EN_IVA2_MASK (1 << 2)
>
> /* PM_EVGENCTRL_MPU */
> #define OMAP3430_OFFLOADMODE_SHIFT 3
>
> --
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-16 21:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 14:46 [PATCH 0/5] Powerdomains: add OMAP2/3 powerdomain code, and common OMAP type bitfield Paul Walmsley
2008-04-10 14:46 ` [PATCH 1/5] Powerdomains: add OMAP chip type global bitfield; clean up mach-omap2/id.c Paul Walmsley
2008-04-16 21:20 ` Tony Lindgren
2008-04-18 5:48 ` Högander Jouni
2008-04-18 5:53 ` Paul Walmsley
2008-04-10 14:46 ` [PATCH 2/5] Powerdomains: add base OMAP2/3 powerdomain code Paul Walmsley
2008-04-16 21:31 ` Tony Lindgren
2008-04-10 14:46 ` [PATCH 3/5] Powerdomains: add OMAP2/3 common powerdomains Paul Walmsley
2008-04-10 14:46 ` [PATCH 4/5] Powerdomains: add OMAP2 powerdomains Paul Walmsley
2008-04-10 14:46 ` [PATCH 5/5] Powerdomains: Add OMAP3 powerdomains Paul Walmsley
2008-04-16 21:42 ` Tony Lindgren [this message]
2008-04-17 16:23 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416214228.GO17055@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox