From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: omap2/pm.c build errors
Date: Wed, 16 Apr 2008 14:44:27 -0700 [thread overview]
Message-ID: <20080416214427.GP17055@atomide.com> (raw)
In-Reply-To: <20080416211200.GJ17055@atomide.com>
* Tony Lindgren <tony@atomide.com> [080416 14:12]:
> * David Brownell <david-b@pacbell.net> [080416 11:51]:
> > arch/arm/mach-omap2/pm.c: In function 'pm_init_serial_console':
> > arch/arm/mach-omap2/pm.c:188: error: expected ';' before 'break'
> > arch/arm/mach-omap2/pm.c:191: error: expected ';' before 'break'
> > arch/arm/mach-omap2/pm.c:193: error: 'PM_WKEN2' undeclared (first use in this function)
> > arch/arm/mach-omap2/pm.c:193: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-omap2/pm.c:193: error: for each function it appears in.)
> > arch/arm/mach-omap2/pm.c:194: error: expected ';' before 'break'
> >
> >
> > ... wasn't there a patch for this? That's with current GIT.
>
> Hmmm, I don't think so.
Actually, yes, there's a patch from Hiroshi for this, will apply
that one.
> > The "no semicolons after function calls" fix is obvious (and
> > is also a "that patch was never build-tested), but WKEN2 is
> > not quite clear (but see my guess below).
>
> Heh, this looks easy to miss as it's behind CONFIG_PM_DEBUG :)
>
> FYI, the PM code will be split to common pm.c and pm24xx.c and
> pm34xx.c most likely. Then all the serial PM debug code will get
> moved to serial driver.
>
> Care to S-o-b: this patch?
>
> Tony
>
> >
> >
> > --- a/arch/arm/mach-omap2/pm.c
> > +++ b/arch/arm/mach-omap2/pm.c
> > @@ -184,13 +184,13 @@ static void pm_init_serial_console(void)
> > }
> > switch (serial_console_uart) {
> > case 1:
> > - prm_set_mod_reg_bits(OMAP24XX_ST_UART1, CORE_MOD, PM_WKEN1)
> > + prm_set_mod_reg_bits(OMAP24XX_ST_UART1, CORE_MOD, PM_WKEN1);
> > break;
> > case 2:
> > - prm_set_mod_reg_bits(OMAP24XX_ST_UART2, CORE_MOD, PM_WKEN1)
> > + prm_set_mod_reg_bits(OMAP24XX_ST_UART2, CORE_MOD, PM_WKEN1);
> > break;
> > case 3:
> > - prm_set_mod_reg_bits(OMAP24XX_ST_UART3, CORE_MOD, PM_WKEN2)
> > + prm_set_mod_reg_bits(OMAP24XX_ST_UART3, CORE_MOD, OMAP24XX_PM_WKEN2);
> > break;
> > }
> > }
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-04-16 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 18:50 omap2/pm.c build errors David Brownell
2008-04-16 21:12 ` Tony Lindgren
2008-04-16 21:44 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416214427.GP17055@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox