[PATCH 2/2] Add usb support to omap3beagle

[PATCH 2/2] Add usb support to omap3beagle

[Koen Kooi]

[-- Attachment #1: add-beagle-usb-support.diff --]
[-- Type: application/octet-stream, Size: 1179 bytes --]

omap3beagle: register USB interface

Signed-off-by: Koen Kooi <koen@openembedded.org>
---
 Makefile            |    3 ++-
 board-omap3beagle.c |    2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)
--- /tmp/board-omap3beagle.c	2008-04-16 21:23:59.342654625 +0200
+++ git/arch/arm/mach-omap2/board-omap3beagle.c	2008-04-16 21:26:13.119328284 +0200
@@ -62,6 +62,7 @@
 };
 
 extern void __init sdp_mmc_init(void);
+extern void __init sdp3430_usb_init(void);
 
 static void __init omap3_beagle_init(void)
 {
@@ -69,6 +70,7 @@
 	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
 	omap_serial_init();
 	sdp_mmc_init();
+	sdp3430_usb_init();
 }
 
 arch_initcall(omap3_beagle_i2c_init);
--- /tmp/Makefile	2008-04-16 21:23:50.215989366 +0200
+++ git/arch/arm/mach-omap2/Makefile	2008-04-16 21:25:17.306636571 +0200
@@ -36,7 +36,8 @@
 					   board-3430sdp-flash.o
 obj-$(CONFIG_MACH_OMAP3EVM)		+= board-omap3evm.o
 obj-$(CONFIG_MACH_OMAP3_BEAGLE)		+= board-omap3beagle.o \
-					   board-sdp-hsmmc.o 
+					   board-sdp-hsmmc.o \
+					   board-3430sdp-usb.o
 obj-$(CONFIG_MACH_OMAP_APOLLON)		+= board-apollon.o \
 					   board-apollon-mmc.o	\
 					   board-apollon-keys.o

Re: [PATCH 2/2] Add usb support to omap3beagle

[David Brownell]

On Thursday 17 April 2008, Koen Kooi wrote:
> 
> @@ -69,6 +70,7 @@
>  	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
>  	omap_serial_init();
>  	sdp_mmc_init();
> +	sdp3430_usb_init();
>  }
>
>  arch_initcall(omap3_beagle_i2c_init);

I hope someone makes those sdp_*() routines generic ... or does
"SDP" not stand for "Software Development Platform" (different board)?

Re: [PATCH 2/2] Add usb support to omap3beagle

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Op 17 apr 2008, om 20:26 heeft David Brownell het volgende geschreven:
> On Thursday 17 April 2008, Koen Kooi wrote:
>>
>> @@ -69,6 +70,7 @@
>> 	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
>> 	omap_serial_init();
>> 	sdp_mmc_init();
>> +	sdp3430_usb_init();
>> }
>>
>> arch_initcall(omap3_beagle_i2c_init);
>
> I hope someone makes those sdp_*() routines generic ... or does
> "SDP" not stand for "Software Development Platform" (different board)?

Those routines are indeed name after the sdp board, but they seem  
generic enough to get reused in other boards (e.g. omap3evm or omap3  
beagle) without change :)

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFIB522MkyGM64RGpERAqmvAKC8ASHDj63mcwe5bsa2X8OiOUpgAQCfdcZl
6RL3JX4fBhN4NK3rh3XOhTg=
=/Erq
-----END PGP SIGNATURE-----

Re: [PATCH 2/2] Add usb support to omap3beagle

[David Brownell]

On Thursday 17 April 2008, Koen Kooi wrote:
> >>
> >> @@ -69,6 +70,7 @@
> >>      omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
> >>      omap_serial_init();
> >>      sdp_mmc_init();
> >> +    sdp3430_usb_init();
> >> }
> >>
> >> arch_initcall(omap3_beagle_i2c_init);
> >
> > I hope someone makes those sdp_*() routines generic ... or does
> > "SDP" not stand for "Software Development Platform" (different board)?
> 
> Those routines are indeed name after the sdp board, but they seem
> generic enough to get reused in other boards (e.g. omap3evm or omap3
> beagle) without change :)

They aren't quite generic enough ... with those names!  :)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] Add usb support to omap3beagle

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [080417 12:36]:
> On Thursday 17 April 2008, Koen Kooi wrote:
> > >>
> > >> @@ -69,6 +70,7 @@
> > >>      omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
> > >>      omap_serial_init();
> > >>      sdp_mmc_init();
> > >> +    sdp3430_usb_init();
> > >> }
> > >>
> > >> arch_initcall(omap3_beagle_i2c_init);
> > >
> > > I hope someone makes those sdp_*() routines generic ... or does
> > > "SDP" not stand for "Software Development Platform" (different board)?
> > 
> > Those routines are indeed name after the sdp board, but they seem
> > generic enough to get reused in other boards (e.g. omap3evm or omap3
> > beagle) without change :)
> 
> They aren't quite generic enough ... with those names!  :)

Yeah the files should be just twl4030-hsmmc.c instead of
board-sdp-hsmmmc.c.

And usb-musb.c instead of board-2430sdp-usb.c and board-3430sdp-usb.c.

I guess let's do that change next week after we've tagged 2.6.25-omap1.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] Add usb support to omap3beagle

[Felipe Balbi]

On Thu, Apr 17, 2008 at 10:58:32AM +0200, Koen Kooi wrote:

The last one didn't go to the list, both mmc and usb externs should go
to board-omap3beagle.h

and please, care to make the patch inline. It's easier to comment.

-- 
Best Regards,

Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com