Re: [PATCH 2/2] Add usb support to omap3beagle

Tony Lindgren
2008-04-18T18:50:04Z

* David Brownell <david-b@pacbell.net> [080417 12:36]:
> On Thursday 17 April 2008, Koen Kooi wrote:
> > >>
> > >> @@ -69,6 +70,7 @@
> > >>      omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
> > >>      omap_serial_init();
> > >>      sdp_mmc_init();
> > >> +    sdp3430_usb_init();
> > >> }
> > >>
> > >> arch_initcall(omap3_beagle_i2c_init);
> > >
> > > I hope someone makes those sdp_*() routines generic ... or does
> > > "SDP" not stand for "Software Development Platform" (different board)?
> >
> > Those routines are indeed name after the sdp board, but they seem
> > generic enough to get reused in other boards (e.g. omap3evm or omap3
> > beagle) without change :)
>
> They aren't quite generic enough ... with those names! :)

Yeah the files should be just twl4030-hsmmc.c instead of
board-sdp-hsmmmc.c.

And usb-musb.c instead of board-2430sdp-usb.c and board-3430sdp-usb.c.

I guess let's do that change next week after we've tagged 2.6.25-omap1.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html