Re: [PATCH 1/2] ARM: OMAP: CLKFW: Initial debugfs support for omap clock framework

Hiroshi DOYU
2008-04-17T18:57:52Z

Hi,

From: "ext Paul Walmsley" <paul@pwsan.com>
Subject: Re: [PATCH 1/2] ARM: OMAP: CLKFW: Initial debugfs support for omap clock framework
Date: Thu, 17 Apr 2008 12:45:02 -0600 (MDT)

> Hello David,
>
> On Thu, 17 Apr 2008, David Brownell wrote:
>
> > On Thursday 17 April 2008, Paul Walmsley wrote:
> > > But it would be nice to be able to call into clock functions like
> > > round_rate, set_rate, and set_parent via filesystem writes for debugging
> > > purposes, and I don't think that debugfs supports this.
> >
> > It does, if you set up the files properly ... except
> > maybe the set_parent stuff.
>
> Could you be more specific? The only write support that I see in the
> debugfs API is to store bytes into memory locations. We'd need to call
> functions also upon writes.

"debugfs_create_file(...fops)" has take "fops" as its argument. I
guess that this can deal with the above.

For "set_parent", would it be possible to do that by using
"debugfs_rename()"?

And if there will be a little possibility that sysfs attribute can be
used by userland in the future, keeping sysfs instead of debugfs
doesn't seem not so illegal, does it?

Hiroshi DOYU