From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: ext Tony Lindgren <tony@atomide.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: Re: [RFC/PATCH 1/1] ASoC: Add drivers for the Texas Instruments OMAP processors
Date: Tue, 22 Apr 2008 09:49:28 +0100 [thread overview]
Message-ID: <20080422084928.GA1853@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20080422094845.722a949c.jarkko.nikula@nokia.com>
On Tue, Apr 22, 2008 at 09:48:45AM +0300, Jarkko Nikula wrote:
> "ext Tony Lindgren" <tony@atomide.com> wrote:
> > The platform_device_register() should be done in board-*.c files.
> This is a valid point. I think it should be possible to have also in
> ASoC v1 e.g n810_mcbsp_aic33 driver whose probe function would be more
> or less like n810_soc_init now. At least sound/soc/fsl/mpc8610_hpcd.c is
> doing similar thing.
> Mark, any thoughts?
Leave it as-is for ASoC v1, the soc-audio device can't meaningfully be
defined in the platform data. ASoC v2 lets you define a device for the
platform driver for the particular board (as well as for things like I2S
controllers on the SoC) which deals with this a lot better.
next prev parent reply other threads:[~2008-04-22 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 9:22 [RFC/PATCH 0/1] ALSA SoC support for OMAP Jarkko Nikula
2008-04-04 9:22 ` [RFC/PATCH 1/1] ASoC: Add drivers for the Texas Instruments OMAP processors Jarkko Nikula
2008-04-21 18:16 ` Tony Lindgren
2008-04-22 6:48 ` Jarkko Nikula
2008-04-22 8:49 ` Mark Brown [this message]
2008-04-23 23:59 ` [alsa-devel] " Tony Lindgren
2008-04-04 12:42 ` [RFC/PATCH 0/1] ALSA SoC support for OMAP Mark Brown
2008-04-04 13:31 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422084928.GA1853@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox