[PATCH 1/3] ARM: Create an ARM debugfs root.

[PATCH 1/3] ARM: Create an ARM debugfs root.

[Hiroshi DOYU]

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/kernel/setup.c  |   14 ++++++++++++++
 include/asm-arm/system.h |    2 ++
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index b7b0720..1b1e6e4 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -24,6 +24,7 @@
 #include <linux/interrupt.h>
 #include <linux/smp.h>
 #include <linux/fs.h>
+#include <linux/debugfs.h>
 
 #include <asm/cpu.h>
 #include <asm/elf.h>
@@ -1007,3 +1008,16 @@ const struct seq_operations cpuinfo_op = {
 	.stop	= c_stop,
 	.show	= c_show
 };
+
+#ifdef CONFIG_DEBUG_FS
+struct dentry *arm_debugfs_root;
+static int __init arm_debugfs_init(void)
+{
+	arm_debugfs_root = debugfs_create_dir("arm", NULL);
+	if (IS_ERR(arm_debugfs_root))
+		return PTR_ERR(arm_debugfs_root);
+
+	return 0;
+}
+arch_initcall(arm_debugfs_init);
+#endif
diff --git a/include/asm-arm/system.h b/include/asm-arm/system.h
index 6335de9..a6be185 100644
--- a/include/asm-arm/system.h
+++ b/include/asm-arm/system.h
@@ -378,6 +378,8 @@ extern void enable_hlt(void);
 #include <asm-generic/cmpxchg.h>
 #endif
 
+extern struct dentry *arm_debugfs_root;
+
 #endif /* __ASSEMBLY__ */
 
 #define arch_align_stack(x) (x)
-- 
1.5.5.rc2.6.gf58d

[PATCH 2/3] ARM: OMAP: Create an OMAP debugfs root.

[Hiroshi DOYU]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 2056 bytes --]

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/plat-omap/common.c       |   16 +++++++++++++++-
 include/asm-arm/arch-omap/board.h |    4 +++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
index fd6f329..f80dab8 100644
--- a/arch/arm/plat-omap/common.c
+++ b/arch/arm/plat-omap/common.c
@@ -9,7 +9,6 @@
  */
 #include <linux/module.h>
 #include <linux/kernel.h>
-#include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/pm.h>
 #include <linux/console.h>
@@ -18,6 +17,7 @@
 #include <linux/serial_8250.h>
 #include <linux/serial_reg.h>
 #include <linux/clk.h>
+#include <linux/debugfs.h>
 
 #include <asm/hardware.h>
 #include <asm/system.h>
@@ -288,3 +288,17 @@ void __init omap2_set_globals_343x(void)
 }
 #endif
 
+#ifdef CONFIG_DEBUG_FS
+struct dentry *omap_debugfs_root;
+static int __init omap_debugfs_init(void)
+{
+	struct dentry *d;
+
+	d = debugfs_create_dir("omap", arm_debugfs_root);
+	if (IS_ERR(d))
+		return PTR_ERR(d);
+	omap_debugfs_root = d;
+	return 0;
+}
+arch_initcall(omap_debugfs_init);
+#endif
diff --git a/include/asm-arm/arch-omap/board.h b/include/asm-arm/arch-omap/board.h
index 3763f3e..d94065b 100644
--- a/include/asm-arm/arch-omap/board.h
+++ b/include/asm-arm/arch-omap/board.h
@@ -3,7 +3,7 @@
  *
  *  Information structures for board-specific data
  *
- *  Copyright (C) 2004	Nokia Corporation
+ *  Copyright (C) 2004-2008	Nokia Corporation
  *  Written by Juha Yrjölä <juha.yrjola@nokia.com>
  */
 
@@ -196,4 +196,6 @@ extern int omap_board_config_size;
 /* for TI reference platforms sharing the same debug card */
 extern int debug_card_init(u32 addr, unsigned gpio);
 
+extern struct dentry *omap_debugfs_root;
+
 #endif
-- 
1.5.5.rc2.6.gf58d

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] ARM: OMAP: Expose omap tags as debugfs binary blob

[Hiroshi DOYU]

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/plat-omap/common.c |   21 ++++++++++++++++++++-
 1 files changed, 20 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
index f80dab8..5a501e1 100644
--- a/arch/arm/plat-omap/common.c
+++ b/arch/arm/plat-omap/common.c
@@ -289,7 +289,26 @@ void __init omap2_set_globals_343x(void)
 #endif
 
 #ifdef CONFIG_DEBUG_FS
+
 struct dentry *omap_debugfs_root;
+
+#ifdef CONFIG_OMAP_BOOT_TAG
+static int __init add_tag_blob(void)
+{
+	struct dentry *d;
+	static struct debugfs_blob_wrapper blob;
+
+	blob.data = omap_bootloader_tag;
+	blob.size = omap_bootloader_tag_len;
+
+	d = debugfs_create_blob("tag", 0444, omap_debugfs_root, &blob);
+	if (IS_ERR(d))
+		return PTR_ERR(d);
+	return 0;
+}
+late_initcall(add_tag_blob);
+#endif
+
 static int __init omap_debugfs_init(void)
 {
 	struct dentry *d;
@@ -301,4 +320,4 @@ static int __init omap_debugfs_init(void)
 	return 0;
 }
 arch_initcall(omap_debugfs_init);
-#endif
+#endif	/* CONFIG_DEBUG_FS */
-- 
1.5.5.rc2.6.gf58d

Re: [PATCH 3/3] ARM: OMAP: Expose omap tags as debugfs binary blob

[Tony Lindgren]

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080422 00:17]:
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>  arch/arm/plat-omap/common.c |   21 ++++++++++++++++++++-
>  1 files changed, 20 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
> index f80dab8..5a501e1 100644
> --- a/arch/arm/plat-omap/common.c
> +++ b/arch/arm/plat-omap/common.c
> @@ -289,7 +289,26 @@ void __init omap2_set_globals_343x(void)
>  #endif
>  
>  #ifdef CONFIG_DEBUG_FS
> +
>  struct dentry *omap_debugfs_root;
> +
> +#ifdef CONFIG_OMAP_BOOT_TAG
> +static int __init add_tag_blob(void)
> +{
> +	struct dentry *d;
> +	static struct debugfs_blob_wrapper blob;
> +
> +	blob.data = omap_bootloader_tag;
> +	blob.size = omap_bootloader_tag_len;
> +
> +	d = debugfs_create_blob("tag", 0444, omap_debugfs_root, &blob);
> +	if (IS_ERR(d))
> +		return PTR_ERR(d);
> +	return 0;
> +}
> +late_initcall(add_tag_blob);
> +#endif
> +
>  static int __init omap_debugfs_init(void)
>  {
>  	struct dentry *d;
> @@ -301,4 +320,4 @@ static int __init omap_debugfs_init(void)
>  	return 0;
>  }
>  arch_initcall(omap_debugfs_init);
> -#endif
> +#endif	/* CONFIG_DEBUG_FS */
> -- 
> 1.5.5.rc2.6.gf58d

The omap specific ATAGs are not going to mainline as discussed on
few occasions already over past few years..

We should convert all omap specific ATAGs to be arm generic ATAGs
and get rid of the rest and use data in board-*.c files. We can
add a generic ATAG_BOARD_REVISION or similar to set GPIO pins
in board-*.c files based on the board revision.

Tony

Re: [PATCH 1/3] ARM: Create an ARM debugfs root.

[Tony Lindgren]

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080422 00:17]:
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>  arch/arm/kernel/setup.c  |   14 ++++++++++++++
>  include/asm-arm/system.h |    2 ++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index b7b0720..1b1e6e4 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -24,6 +24,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/smp.h>
>  #include <linux/fs.h>
> +#include <linux/debugfs.h>
>  
>  #include <asm/cpu.h>
>  #include <asm/elf.h>
> @@ -1007,3 +1008,16 @@ const struct seq_operations cpuinfo_op = {
>  	.stop	= c_stop,
>  	.show	= c_show
>  };
> +
> +#ifdef CONFIG_DEBUG_FS
> +struct dentry *arm_debugfs_root;
> +static int __init arm_debugfs_init(void)
> +{
> +	arm_debugfs_root = debugfs_create_dir("arm", NULL);
> +	if (IS_ERR(arm_debugfs_root))
> +		return PTR_ERR(arm_debugfs_root);
> +
> +	return 0;
> +}
> +arch_initcall(arm_debugfs_init);
> +#endif
> diff --git a/include/asm-arm/system.h b/include/asm-arm/system.h
> index 6335de9..a6be185 100644
> --- a/include/asm-arm/system.h
> +++ b/include/asm-arm/system.h
> @@ -378,6 +378,8 @@ extern void enable_hlt(void);
>  #include <asm-generic/cmpxchg.h>
>  #endif
>  
> +extern struct dentry *arm_debugfs_root;
> +
>  #endif /* __ASSEMBLY__ */
>  
>  #define arch_align_stack(x) (x)
> -- 
> 1.5.5.rc2.6.gf58d

This one should be discussed first on the linux-arm-kernel list.

Tony