From: Tony Lindgren <tony@atomide.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Add return value check for input_register_device()
Date: Tue, 22 Apr 2008 12:24:05 -0700 [thread overview]
Message-ID: <20080422192403.GH24257@atomide.com> (raw)
In-Reply-To: <1208870502-13321-1-git-send-email-Hiroshi.DOYU@nokia.com>
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080422 06:26]:
> drivers/cbus/retu-pwrbutton.c:100: warning: ignoring return value of 'input_register_device', declared with attribute warn_unused_result
>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
> drivers/cbus/retu-pwrbutton.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cbus/retu-pwrbutton.c b/drivers/cbus/retu-pwrbutton.c
> index 283d9ca..38d7aa4 100644
> --- a/drivers/cbus/retu-pwrbutton.c
> +++ b/drivers/cbus/retu-pwrbutton.c
> @@ -97,9 +97,7 @@ static int __init retubutton_init(void)
> pwrbtn_dev->keybit[BIT_WORD(KEY_POWER)] = BIT_MASK(KEY_POWER);
> pwrbtn_dev->name = "retu-pwrbutton";
>
> - input_register_device(pwrbtn_dev);
> -
> - return 0;
> + return input_register_device(pwrbtn_dev);
> }
>
> /**
Pushing.
Tony
prev parent reply other threads:[~2008-04-22 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 13:21 [PATCH] ARM: OMAP: Add return value check for input_register_device() Hiroshi DOYU
2008-04-22 19:24 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422192403.GH24257@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox