Re: [PATCH] USB: Generalize usb initialization for omap hw

Tony Lindgren
2008-04-24T21:32:02Z

* Felipe Balbi <me@felipebalbi.com> [080424 14:07]:
> On Thu, Apr 24, 2008 at 01:48:11PM -0700, Tony Lindgren wrote:
> > * David Brownell <david-b@pacbell.net> [080424 12:07]:
> > > Looks better to me, but:
> > >
> > > On Thursday 24 April 2008, Felipe Balbi wrote:
> > > > +static void setup_ehci_io_mux(void)
> > > > +{
> > > > +#ifdef CONFIG_OMAP_EHCI_PHY_MODE
> > >
> > > This PHY_MODE thing should probably be provided by the board
> > > data not Kconfig, and
> > >
> > > > +       /* PHY mode of operation for board: 750-2083-001
> > > > +        * ISP1504 connected to Port1 and Port2
> > > > +        * Do Func Mux setting for 12-pin ULPI PHY mode
> > > > +        */
> > > > +
> > > > +       /* Port1 */
> > > > +       omap_cfg_reg(Y9_3430_USB1HS_PHY_STP);
> > > > +       omap_cfg_reg(Y8_3430_USB1HS_PHY_CLK);
> > > > ...
> > >
> > > All those MUX options should be driven by the board data too.
> > >
> > > Unless it's for some reason not possible to configure only one
> > > of the three EHCI ports at a time...
> > >
> > > This patch being cleanup-only, I don't suggest you fix that
> > > at this time.
> >
> > OK, I'll push Felipe's patch today.
>
> Thanks tony, i'll check dave's comments tomorrow then. Maybe i can come
> up with some stuff soon.

Great. While at it, can you also set the TWL4030_IRQNUM during init based
on cpu_is_omap() macros? I already got rid of all the other TWL defines
in board-*.h files as you already probably noticed.

That way we can remove it from the board-*.h files as it would block
compiling in multiple omaps.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html