Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

Tony Lindgren
2008-04-24T17:12:08Z

* Gadiyar, Anand <gadiyar@ti.com> [080424 07:17]:
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org
> > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Felipe Balbi
> > Sent: Thursday, April 24, 2008 7:16 PM
> > To: linux-omap@vger.kernel.org; David Brownell
> > Cc: Tony Lindgren; Syed Mohammed, Khasim; Felipe Balbi
> > Subject: [PATCH 2/2] USB: Generalize usb initialization for omap hw
> >
> > Create a generic board-file for initializing usb
> > on omap2430 and omap3 boards.
> >
> > Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> > ---
> > arch/arm/mach-omap2/Makefile | 4 +-
> > arch/arm/mach-omap2/board-2430sdp-usb.c | 96
> > --------------------
> > arch/arm/mach-omap2/board-2430sdp.c | 3 +-
> > arch/arm/mach-omap2/board-3430sdp.c | 3 +-
> > .../mach-omap2/{board-3430sdp-usb.c => usb-musb.c} | 32 ++++---
> > include/asm-arm/arch-omap/usb-musb.h | 35 +++++++
>
> usb-musb.{c,h}? EHCI/OHCI has nothing to do with mentor.

This is all musb stuff, no? If not, there should be a separate
usb-ehci.c.

Tony

> > 6 files changed, 61 insertions(+), 112 deletions(-)
> > delete mode 100644 arch/arm/mach-omap2/board-2430sdp-usb.c
> > rename arch/arm/mach-omap2/{board-3430sdp-usb.c => usb-musb.c} (91%)
> > create mode 100644 include/asm-arm/arch-omap/usb-musb.h
> >