Re: pending patch

[David Brownell <david-b@pacbell.net>]

On Friday 25 April 2008, Felipe Balbi wrote:
> Hi Tony and Dave,
> 
> there's this one pending patch [1]. Do you guys have any comments on that
> one?
> 
> Author: Felipe Balbi <felipe.balbi@nokia.com>
> Date:   Thu Apr 17 17:34:20 2008 +0300
> 
>     USB: MUSB: Don't ignore disconnect on suspend
>     
>     As soon as a usb device is disconnect we should
>     fall into a_wait_bcon state, ignoring disconnect
>     irq will prevent this behaviour.

If it passes the OTG tests, fine.  I don't recall how the
HNP handoff's disconnect signaling is handled ... presumably
it's different from some "real" disconnect.



>     Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index c5816a2..019898a 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -659,7 +659,7 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
>                         switch (musb->xceiv.state) {
>  #ifdef CONFIG_USB_OTG
>                         case OTG_STATE_A_SUSPEND:
> -                               musb->ignore_disconnect = 1;
> +                               musb->ignore_disconnect = 0;
>                                 musb_g_reset(musb);
>                                 /* FALLTHROUGH */
>                         case OTG_STATE_A_WAIT_BCON:     /* OPT TD.4.7-900ms */
> 
> [1] http://marc.info/?l=linux-omap&m=120844324526642&w=2
> -- 
> 	- Balbi
>