* [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init
@ 2008-04-25 19:05 Francisco Alecrim
2008-04-25 23:33 ` Felipe Balbi
2008-04-30 0:22 ` Tony Lindgren
0 siblings, 2 replies; 3+ messages in thread
From: Francisco Alecrim @ 2008-04-25 19:05 UTC (permalink / raw)
To: linux-omap; +Cc: Francisco Alecrim
From: Francisco Alecrim <francisco.alecrim@indt.org.br>
Remove unnecessary extern sdp_mmc_init() at board header. New extern
hsmmc_init() defined include/asm-arm/arch-omap/hsmmc.h.
Signed-off-by: Francisco Alecrim <francisco.alecrim@indt.org.br>
Acked-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
---
include/asm-arm/arch-omap/board-2430sdp.h | 1 -
include/asm-arm/arch-omap/board-3430sdp.h | 1 -
include/asm-arm/arch-omap/board-omap3beagle.h | 2 --
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h
index ad682c5..b308e88 100644
--- a/include/asm-arm/arch-omap/board-2430sdp.h
+++ b/include/asm-arm/arch-omap/board-2430sdp.h
@@ -39,6 +39,5 @@
/* Function prototypes */
extern void sdp2430_flash_init(void);
extern void sdp2430_usb_init(void);
-extern void sdp_mmc_init(void);
#endif /* __ASM_ARCH_OMAP_2430SDP_H */
diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h
index 34e878a..77f8647 100644
--- a/include/asm-arm/arch-omap/board-3430sdp.h
+++ b/include/asm-arm/arch-omap/board-3430sdp.h
@@ -30,7 +30,6 @@
#define __ASM_ARCH_OMAP_3430SDP_H
extern void sdp3430_usb_init(void);
-extern void sdp_mmc_init(void);
#define DEBUG_BASE 0x08000000 /* debug board */
diff --git a/include/asm-arm/arch-omap/board-omap3beagle.h b/include/asm-arm/arch-omap/board-omap3beagle.h
index 782e2e5..14db589 100644
--- a/include/asm-arm/arch-omap/board-omap3beagle.h
+++ b/include/asm-arm/arch-omap/board-omap3beagle.h
@@ -29,8 +29,6 @@
#ifndef __ASM_ARCH_OMAP3_BEAGLE_H
#define __ASM_ARCH_OMAP3_BEAGLE_H
-extern void sdp_mmc_init(void);
-
#define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
#endif /* __ASM_ARCH_OMAP3_BEAGLE_H */
--
1.5.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init
2008-04-25 19:05 [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init Francisco Alecrim
@ 2008-04-25 23:33 ` Felipe Balbi
2008-04-30 0:22 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2008-04-25 23:33 UTC (permalink / raw)
To: Francisco Alecrim; +Cc: linux-omap
On Fri, Apr 25, 2008 at 10:05:02PM +0300, Francisco Alecrim wrote:
> From: Francisco Alecrim <francisco.alecrim@indt.org.br>
>
> Remove unnecessary extern sdp_mmc_init() at board header. New extern
> hsmmc_init() defined include/asm-arm/arch-omap/hsmmc.h.
>
> Signed-off-by: Francisco Alecrim <francisco.alecrim@indt.org.br>
> Acked-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
Good catch... let this one out when generalizing mmc init routine.
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> include/asm-arm/arch-omap/board-2430sdp.h | 1 -
> include/asm-arm/arch-omap/board-3430sdp.h | 1 -
> include/asm-arm/arch-omap/board-omap3beagle.h | 2 --
> 3 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h
> index ad682c5..b308e88 100644
> --- a/include/asm-arm/arch-omap/board-2430sdp.h
> +++ b/include/asm-arm/arch-omap/board-2430sdp.h
> @@ -39,6 +39,5 @@
> /* Function prototypes */
> extern void sdp2430_flash_init(void);
> extern void sdp2430_usb_init(void);
> -extern void sdp_mmc_init(void);
>
> #endif /* __ASM_ARCH_OMAP_2430SDP_H */
> diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h
> index 34e878a..77f8647 100644
> --- a/include/asm-arm/arch-omap/board-3430sdp.h
> +++ b/include/asm-arm/arch-omap/board-3430sdp.h
> @@ -30,7 +30,6 @@
> #define __ASM_ARCH_OMAP_3430SDP_H
>
> extern void sdp3430_usb_init(void);
> -extern void sdp_mmc_init(void);
>
> #define DEBUG_BASE 0x08000000 /* debug board */
>
> diff --git a/include/asm-arm/arch-omap/board-omap3beagle.h b/include/asm-arm/arch-omap/board-omap3beagle.h
> index 782e2e5..14db589 100644
> --- a/include/asm-arm/arch-omap/board-omap3beagle.h
> +++ b/include/asm-arm/arch-omap/board-omap3beagle.h
> @@ -29,8 +29,6 @@
> #ifndef __ASM_ARCH_OMAP3_BEAGLE_H
> #define __ASM_ARCH_OMAP3_BEAGLE_H
>
> -extern void sdp_mmc_init(void);
> -
> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
>
> #endif /* __ASM_ARCH_OMAP3_BEAGLE_H */
> --
> 1.5.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards,
Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init
2008-04-25 19:05 [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init Francisco Alecrim
2008-04-25 23:33 ` Felipe Balbi
@ 2008-04-30 0:22 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-04-30 0:22 UTC (permalink / raw)
To: Francisco Alecrim; +Cc: linux-omap
* Francisco Alecrim <francisco.alecrim@indt.org.br> [080425 12:27]:
> From: Francisco Alecrim <francisco.alecrim@indt.org.br>
>
> Remove unnecessary extern sdp_mmc_init() at board header. New extern
> hsmmc_init() defined include/asm-arm/arch-omap/hsmmc.h.
Pushing today.
Tony
> Signed-off-by: Francisco Alecrim <francisco.alecrim@indt.org.br>
> Acked-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
> include/asm-arm/arch-omap/board-2430sdp.h | 1 -
> include/asm-arm/arch-omap/board-3430sdp.h | 1 -
> include/asm-arm/arch-omap/board-omap3beagle.h | 2 --
> 3 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h
> index ad682c5..b308e88 100644
> --- a/include/asm-arm/arch-omap/board-2430sdp.h
> +++ b/include/asm-arm/arch-omap/board-2430sdp.h
> @@ -39,6 +39,5 @@
> /* Function prototypes */
> extern void sdp2430_flash_init(void);
> extern void sdp2430_usb_init(void);
> -extern void sdp_mmc_init(void);
>
> #endif /* __ASM_ARCH_OMAP_2430SDP_H */
> diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h
> index 34e878a..77f8647 100644
> --- a/include/asm-arm/arch-omap/board-3430sdp.h
> +++ b/include/asm-arm/arch-omap/board-3430sdp.h
> @@ -30,7 +30,6 @@
> #define __ASM_ARCH_OMAP_3430SDP_H
>
> extern void sdp3430_usb_init(void);
> -extern void sdp_mmc_init(void);
>
> #define DEBUG_BASE 0x08000000 /* debug board */
>
> diff --git a/include/asm-arm/arch-omap/board-omap3beagle.h b/include/asm-arm/arch-omap/board-omap3beagle.h
> index 782e2e5..14db589 100644
> --- a/include/asm-arm/arch-omap/board-omap3beagle.h
> +++ b/include/asm-arm/arch-omap/board-omap3beagle.h
> @@ -29,8 +29,6 @@
> #ifndef __ASM_ARCH_OMAP3_BEAGLE_H
> #define __ASM_ARCH_OMAP3_BEAGLE_H
>
> -extern void sdp_mmc_init(void);
> -
> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
>
> #endif /* __ASM_ARCH_OMAP3_BEAGLE_H */
> --
> 1.5.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-30 0:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-25 19:05 [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init Francisco Alecrim
2008-04-25 23:33 ` Felipe Balbi
2008-04-30 0:22 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox