From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] PRCM: Combine 34xx l3_icks and l4_icks Date: Tue, 29 Apr 2008 17:32:34 -0700 Message-ID: <20080430003234.GG8981@atomide.com> References: <873ap69ybi.fsf@trdhcp146196.ntc.nokia.com> <87ej8p6tqg.fsf@trdhcp146196.ntc.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-bos.mailhop.org ([63.208.196.179]:60381 "EHLO mho-02-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755555AbYD3Acj (ORCPT ); Tue, 29 Apr 2008 20:32:39 -0400 Content-Disposition: inline In-Reply-To: <87ej8p6tqg.fsf@trdhcp146196.ntc.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: =?iso-8859-1?Q?H=F6gander?= Jouni Cc: ext Felipe Balbi , linux-omap@vger.kernel.org, ext Paul Walmsley , igor.stoppa@nokia.com * H=C3=B6gander Jouni [080428 23:50]: > "ext Felipe Balbi" writes: >=20 > > On Mon, 28 Apr 2008 11:29:53 +0300, jouni.hogander@nokia.com (H=C3=B6= gander > > Jouni) wrote: > >> E.g dss_l3_ick and dss_l4_ick have same gating control. Having own > >> clock for both of them causes race condition between enable / disa= ble. > >>=20 > >> This patch combines this kind of clocks and names new clock as > >> _ick. > >>=20 > >> Signed-off-by: Jouni Hogander > > > > Good, the following patch fixes ehci-omap.c after clock name change > > :-) >=20 > Sorry, I should have used grep here. I did it now. There are no > other references to changed clock names than this you pointed out. I > checked ca=E1=B8=BF_l3_ick, cam_l4_ick, usbhost_l3_ick, usbhost_l4_ic= k. >=20 > Yes, your patch needs to be applied if "[PATCH] PRCM: Combine 34xx > l3_icks and l4_icks" is applied. I've merged this into Jouni's patch. Tony > > > > Could you check, please: > > > > From 4102f3ad5db10e662633c0f9ddee6aca43fec8e6 Mon Sep 17 00:00:00 2= 001 > > From: Felipe Balbi > > Date: Mon, 28 Apr 2008 13:45:49 +0300 > > Subject: [PATCH] USB: EHCI: Fix clock name for ehci-omap.c > > MIME-Version: 1.0 > > Content-Type: text/plain; charset=3Dutf-8 > > Content-Transfer-Encoding: 8bit > > > > Patch from Jouni H=C3=B6gander changed usbhost_l4_ick to > > usbhost_ick, fixing in ehci-omap.c > > > > Signed-off-by: Felipe Balbi > > Cc: Jouni H=C3=B6gander > > --- > > drivers/usb/host/ehci-omap.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-o= map.c > > index 495c979..be93c69 100644 > > --- a/drivers/usb/host/ehci-omap.c > > +++ b/drivers/usb/host/ehci-omap.c > > @@ -73,7 +73,7 @@ struct ehci_omap_clock_defs { > > }; > > =20 > > /* Clock names as per clock framework: May change so keep as #defs= */ > > -#define USBHOST_ICKL "usbhost_l4_ick" > > +#define USBHOST_ICKL "usbhost_ick" > > #define USBHOST_120M_FCLK "usbhost_120m_fck" > > #define USBHOST_48M_FCLK "usbhost_48m_fck" > > #define USBHOST_TLL_ICKL "usbtll_ick" > > --=20 > > 1.5.5.1.57.g5909c > > > > > > > > --=20 > > Best Regards, > > > > Felipe Balbi > > http://felipebalbi.com > > me@felipebalbi.com > > >=20 > --=20 > Jouni H=C3=B6gander >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html