From: Tony Lindgren <tony@atomide.com>
To: nick loeve <trickie@gmail.com>
Cc: Felipe Balbi <me@felipebalbi.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix n800 build - only register HW keyboard on i2c board if CONFIG_MACH_NOKIA_N810
Date: Fri, 2 May 2008 16:34:35 -0700 [thread overview]
Message-ID: <20080502233434.GF8981@atomide.com> (raw)
In-Reply-To: <83c2b2e00805020624vdad215er5bce9d082e2488e9@mail.gmail.com>
* nick loeve <trickie@gmail.com> [080502 06:25]:
> Hi,
>
> On Fri, May 2, 2008 at 3:17 PM, Felipe Balbi <me@felipebalbi.com> wrote:
> >
> >
> > On Fri, 2 May 2008 15:05:35 +0200, trickie@gmail.com wrote:
> >> lm8323_pdata is only present if CONFIG_MACH_NOKIA_N810
> >
> > that's true but CONFIG_MACH_NOKIA_N810 is always true
> > if you use n800_defconfig.
>
> Yes true. I have been playing with a custom .config based on Tony's
> experiments here: http://www.muru.com/linux/n8x0/ but for my n800
> only.
>
> Hence I noticed this if CONFIG_MACH_NOKIA_N810 is not defined.
Pushing today.
Tony
> >
> > Anyways, good catch.
> >
> >> Signed-off-by: Nick Loeve <trickie@gmail.com>
> >> ---
> >> arch/arm/mach-omap2/board-n800.c | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-omap2/board-n800.c
> >> b/arch/arm/mach-omap2/board-n800.c
> >> index 8b5956b..b62f2d5 100644
> >> --- a/arch/arm/mach-omap2/board-n800.c
> >> +++ b/arch/arm/mach-omap2/board-n800.c
> >> @@ -654,12 +654,14 @@ static struct i2c_board_info __initdata
> >> n800_i2c_board_info_2[] = {
> >> I2C_BOARD_INFO("tea5761", 0x10),
> >> },
> >> #endif
> >> +#ifdef CONFIG_MACH_NOKIA_N810
> >> {
> >> I2C_BOARD_INFO("lm8323", 0x45),
> >> .type = "lm8323",
> >> .irq = OMAP_GPIO_IRQ(109),
> >> .platform_data = &lm8323_pdata,
> >> },
> >> +#endif
> >> {
> >> I2C_BOARD_INFO("tsl2563", 0x29),
> >> .type = "tsl2563",
> >> --
> >> 1.5.5.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > Best Regards,
> >
> > Felipe Balbi
> > http://felipebalbi.com
> > me@felipebalbi.com
> >
> >
>
>
>
> --
> Nick Loeve
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-02 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 13:05 [PATCH] Fix n800 build - only register HW keyboard on i2c board if CONFIG_MACH_NOKIA_N810 trickie
2008-05-02 13:17 ` Felipe Balbi
2008-05-02 13:24 ` nick loeve
2008-05-02 23:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502233434.GF8981@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=trickie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox