From: Tony Lindgren <tony@atomide.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
paul@pwsan.com
Subject: Re: vanilla kernel is broken on omap board
Date: Tue, 6 May 2008 18:19:15 -0700 [thread overview]
Message-ID: <20080507011914.GM18682@atomide.com> (raw)
In-Reply-To: <9c9fda240805061748n3287cb24v530f779b6b622d53@mail.gmail.com>
Hi,
* Kyungmin Park <kmpark@infradead.org> [080506 17:48]:
> Hi Tony,
>
> Current vanilla kernel is broken on omap2 boards.
> In the previous time you committed some omap2 patches, but some
> patches are not missing.
> Such as Runtime constants series. [1]
>
> Now "some parts" are already included.
> So you just commit the remain parts too such as in [2]
> In most cases the board files don't set the their own global variables.
Well at least we're getting closer to making omap2 really usable with
mainline kernel :)
Thanks for fixing that, will add this to omap-fixes queue and send it
upstream with bunch of other fixes.
Regards,
Tony
> Thank you,
> Kyungmin Park
>
> 1. Runtime constants: introduce omap2_set_globals_*()
> http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=2b256e28e8e70592f0c38a862cc4ba0498c9db7b
> Runtime constants: use runtime-computed SDRC base
> http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=7b5f8cdb222052a7aa02ed38c59e0af1946b1e06
> Runtime constants: use runtime-computed SMS base
> http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=80ccf4b99eb3892809bbebf7673bdd1a359d56ff
>
> 2.
> diff --git a/arch/arm/mach-omap2/board-apollon.c b/arch/arm/mach-omap2/board-apo
> index a1e1e67..620fa0f 100644
> --- a/arch/arm/mach-omap2/board-apollon.c
> +++ b/arch/arm/mach-omap2/board-apollon.c
> @@ -394,6 +394,7 @@ static void __init omap_apollon_init(void)
>
> static void __init omap_apollon_map_io(void)
> {
> + omap2_set_globals_242x();
> omap2_map_common_io();
> }
> diff --git a/include/asm-arm/arch-omap/common.h b/include/asm-arm/arch-omap/comm
> index 224e009..36a3b62 100644
> --- a/include/asm-arm/arch-omap/common.h
> +++ b/include/asm-arm/arch-omap/common.h
> @@ -47,4 +47,8 @@ static inline int omap_register_i2c_bus(int bus_id, u32 clkrat
> }
> #endif
>
> +void omap2_set_globals_242x(void);
> +void omap2_set_globals_243x(void);
> +void omap2_set_globals_343x(void);
> +
> #endif /* __ARCH_ARM_MACH_OMAP_COMMON_H */
next prev parent reply other threads:[~2008-05-07 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 0:48 vanilla kernel is broken on omap board Kyungmin Park
2008-05-07 1:19 ` Tony Lindgren [this message]
2008-05-07 23:44 ` Tony Lindgren
2008-05-07 23:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507011914.GM18682@atomide.com \
--to=tony@atomide.com \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox