From: Tony Lindgren <tony@atomide.com>
To: arun c <arunedarath@mistralsolutions.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP:DISPC Register name typo
Date: Wed, 7 May 2008 16:22:00 -0700 [thread overview]
Message-ID: <20080507232159.GS18682@atomide.com> (raw)
In-Reply-To: <c656a4d20805070030k1e5bcd39md4a7d3ce3730c56c@mail.gmail.com>
* arun c <arunedarath@mistralsolutions.com> [080507 00:31]:
> Hi all,
>
> This patch corrects the register name typo in dispc.c.
> False read happens just after the reset(reading DISPC_CONTROL returns
> zero), this
> might be the reason it worked fine without any issue.
Pushing today.
Tony
> ############################################
> From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
> From: arun <arunedarath@mistralsolutions.com>
> Date: Wed, 7 May 2008 12:25:40 +0530
> Subject: [PATCH] OMAP:DISPC Register name typo
>
> DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
>
> Signed-off-by: arun <arunedarath@mistralsolutions.com>
> ---
> drivers/video/omap/dispc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
> index 4c055a2..6aff476 100644
> --- a/drivers/video/omap/dispc.c
> +++ b/drivers/video/omap/dispc.c
> @@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device
> *fbdev, int ext_mode,
> }
>
> /* Enable smart idle and autoidle */
> - l = dispc_read_reg(DISPC_CONTROL);
> + l = dispc_read_reg(DISPC_SYSCONFIG);
> l &= ~((3 << 12) | (3 << 3));
> l |= (2 << 12) | (2 << 3) | (1 << 0);
> dispc_write_reg(DISPC_SYSCONFIG, l);
> --
> 1.5.3.4
>
> ##########################################
>
> Regards,
> Arun C
> From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
> From: arun <arunedarath@mistralsolutions.com>
> Date: Wed, 7 May 2008 12:25:40 +0530
> Subject: [PATCH] OMAP:DISPC Register name typo
>
> DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
>
> Signed-off-by: arun <arunedarath@mistralsolutions.com>
> ---
> drivers/video/omap/dispc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
> index 4c055a2..6aff476 100644
> --- a/drivers/video/omap/dispc.c
> +++ b/drivers/video/omap/dispc.c
> @@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
> }
>
> /* Enable smart idle and autoidle */
> - l = dispc_read_reg(DISPC_CONTROL);
> + l = dispc_read_reg(DISPC_SYSCONFIG);
> l &= ~((3 << 12) | (3 << 3));
> l |= (2 << 12) | (2 << 3) | (1 << 0);
> dispc_write_reg(DISPC_SYSCONFIG, l);
> --
> 1.5.3.4
>
prev parent reply other threads:[~2008-05-07 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 7:30 [PATCH] OMAP:DISPC Register name typo arun c
2008-05-07 23:22 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507232159.GS18682@atomide.com \
--to=tony@atomide.com \
--cc=arunedarath@mistralsolutions.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox